-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populating JSON properties support #83669
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3ba6d9e
Populating JSON properties support
krwq f8e6b77
apply review feedback
krwq 91af9a5
Attempt to fix build by reducing stack frame
krwq 396eb0f
Fix docs
krwq 1cb3f3f
Remove unnecessary properties from ReadStackFrame.
eiriktsarpalis 0e288a6
Move source gen tests to the source gen test project.
eiriktsarpalis 39b2179
Improve test helper method name.
eiriktsarpalis 9d5ad17
Add argument validation to JsonPropertyInfo.ObjectCreationHandling & …
eiriktsarpalis 4b19814
Add test coverage for invalid attribute annotations.
eiriktsarpalis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
src/libraries/System.Text.Json/Common/JsonObjectCreationHandling.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
namespace System.Text.Json.Serialization | ||
{ | ||
|
||
/// <summary> | ||
/// Determines how deserialization will handle object creation for fields or properties. | ||
/// </summary> | ||
#if BUILDING_SOURCE_GENERATOR | ||
internal | ||
#else | ||
public | ||
#endif | ||
enum JsonObjectCreationHandling | ||
{ | ||
/// <summary> | ||
/// A new instance will always be created when deserializing a field or property. | ||
/// </summary> | ||
Replace = 0, | ||
|
||
/// <summary> | ||
/// Attempt to populate any instances already found on a deserialized field or property. | ||
/// </summary> | ||
Populate = 1, | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the
Preferred
prefix refer to? Seems like this property won't win over the setting for properties and objects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct:
now we will use setting in following order:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the very same precedence considerations as with
NumberHandling
above, and that the behavior can be conveyed to users without the "Preferred" prefixThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for number handling it's implied you have number so it's always supported as long as it's a number. Here it's a bit more fuzzy and you might not get what you want (i.e. immutable collections users might think it will append or it won't populate for structs if it doesn't have a setter). We've discussed that during API review and prefix was added during it