Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Interop.LocalAlloc follow-up #84164

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Refactor Interop.LocalAlloc follow-up #84164

merged 1 commit into from
Apr 3, 2023

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Mar 31, 2023 •
edited
Loading

Follow-up #82450.

cc: @AaronRobinsonMSFT

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Mar 31, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 31, 2023
@build-analysis build-analysis bot mentioned this pull request Mar 31, 2023
Closed
@huoyaoyuan huoyaoyuan added area-System.Runtime.InteropServices and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 3, 2023
@ghost
Copy link

ghost commented Apr 3, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Follow-up #82450.

Author: xtqqczze
Assignees: -
Labels:

area-System.Runtime.InteropServices, community-contribution
Milestone: -

@xtqqczze xtqqczze changed the title WIP: Refactor Interop.LocalAlloc follow-up Refactor Interop.LocalAlloc follow-up Apr 3, 2023
@xtqqczze xtqqczze marked this pull request as ready for review April 3, 2023 23:13
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Apr 3, 2023

Test failures appear unrelated.

@AaronRobinsonMSFT
Copy link
Member

Thank you!

@AaronRobinsonMSFT AaronRobinsonMSFT merged commit b1812ef into dotnet:main Apr 3, 2023
@xtqqczze xtqqczze deleted the LocalAlloc2 branch April 6, 2023 14:37
@ghost ghost locked as resolved and limited conversation to collaborators May 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AaronRobinsonMSFT AaronRobinsonMSFT AaronRobinsonMSFT approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.InteropServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtqqczze @AaronRobinsonMSFT @huoyaoyuan