-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0] Disable HardwareIntrinsics failing tests on Mono #84475
[release/6.0] Disable HardwareIntrinsics failing tests on Mono #84475
Conversation
/cc @steveisok |
@kotlarmilos - I think this needs to be open in the staging pipeline, see more guidance from @carlossanlop in email. |
Why not backporting Zoltan's fix instead? #84385 |
@kotlarmilos @SamMonoRT today is code complete. Can you please help make sure this is ready to merge by 4pm EOD today?
|
@carlossanlop - This PR seems ready for merge Yes - the failures are not related to the changes |
@fanyang-mono - We decided to disable the test, mostly as this is a CI failures and not a customer reported issue. We can rethink the actual backport of the fix if there are related issues coming from the field in the future. |
Thanks @SamMonoRT. Then it seems this is ready to merge. I forgot to mention that for tell-mode changes we can automatically add the |
Fixes Issue #81907
Description
This PR disables the failing tests for hardware intrinsics on Mono llvmaot linux arm64. The tests report the following error message:
System.Exception: One or more scenarios did not complete as expected
.Customer Impact
No customer impact, the issue is blocking clean CI.
Testing
Tested on the CI, the tests don't fail as they are disabled.
Risk
Low risk. This PR disables failing intrinsics tests. In .NET 6, Mono had just started implementing intrinsics support, so likely some Library optimizations might have exposed some limitations for Mono.
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.