Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Disable HardwareIntrinsics failing tests on Mono #84475

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Apr 7, 2023

Fixes Issue #81907

Description

This PR disables the failing tests for hardware intrinsics on Mono llvmaot linux arm64. The tests report the following error message: System.Exception: One or more scenarios did not complete as expected.

Customer Impact

No customer impact, the issue is blocking clean CI.

Testing

Tested on the CI, the tests don't fail as they are disabled.

Risk

Low risk. This PR disables failing intrinsics tests. In .NET 6, Mono had just started implementing intrinsics support, so likely some Library optimizations might have exposed some limitations for Mono.

IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@kotlarmilos kotlarmilos self-assigned this Apr 7, 2023
@SamMonoRT SamMonoRT added this to the 6.0.x milestone Apr 7, 2023
@SamMonoRT SamMonoRT added the Servicing-consider Issue for next servicing release review label Apr 7, 2023
@SamMonoRT
Copy link
Member

/cc @steveisok

@SamMonoRT
Copy link
Member

@kotlarmilos - I think this needs to be open in the staging pipeline, see more guidance from @carlossanlop in email.

@SamMonoRT
Copy link
Member

@kotlarmilos - https://github.com/dotnet/runtime/blob/release/7.0-staging/docs/project/library-servicing.md

@fanyang-mono
Copy link
Member

Why not backporting Zoltan's fix instead? #84385

@carlossanlop
Copy link
Member

carlossanlop commented Apr 10, 2023

@kotlarmilos @SamMonoRT today is code complete. Can you please help make sure this is ready to merge by 4pm EOD today?

  • No Tactics approval needed (test change, tell-mode).
  • Please confirm the CI failures are unrelated.
  • Get a sign-off from an area owner.
  • No OOB changes needed (not affecting managed code in libraries code).

@SamMonoRT
Copy link
Member

@carlossanlop - This PR seems ready for merge

Yes - the failures are not related to the changes
I'm the area owner for the aot-llvm area for Mono, I have signed off on the PR.

@SamMonoRT
Copy link
Member

@fanyang-mono - We decided to disable the test, mostly as this is a CI failures and not a customer reported issue. We can rethink the actual backport of the fix if there are related issues coming from the field in the future.

@carlossanlop
Copy link
Member

Thanks @SamMonoRT. Then it seems this is ready to merge.

I forgot to mention that for tell-mode changes we can automatically add the Servicing-approved label to unblock the check-service-labels CI action and enable the Squash & Merge button.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 10, 2023
@kotlarmilos kotlarmilos merged commit c885ca4 into dotnet:release/6.0-staging Apr 10, 2023
@kotlarmilos kotlarmilos deleted the bugfix/disable-hardwareintrinsics-tests branch April 10, 2023 18:01
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-AOT-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants