-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to specify a Spin Count Unit via a GC Configuration to release/7.0 #84495
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsAdded the ability to specify a Spin Count Unit via a GC Configuration for the release/7.0 branch and make use of this value in the SetYieldProcessorScalingFactor function if the value is valid. If this configuration is not specified, we default to 0 and fall back to the original logic. This PR is port of #84339 as automatic merging failed.
|
@mrsharm you have to target the |
@mrsharm, I am removing the servicing consider label until it is reviewed and all the tests are passed. |
@mrsharm today is code complete. If you want this fix included in the May Servicing release, please get it ready by 4pm PT today:
No OOB changes needed since this is a native code change. |
cc @jeffschwMSFT for servicing consider. |
Correct, we are still waiting for customer validation on this and will merge when we have confirmation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. we will bring for consideration in 7.0.x
Added the ability to specify a Spin Count Unit via a GC Configuration for the release/7.0-staging branch and make use of this value in the SetYieldProcessorScalingFactor function if the value is valid. If this configuration is not specified, we default to 0 and fall back to the original logic.
This PR is port of #84339 as automatic merging failed.
Customer impact
There were performance regressions experienced by customers related to this fix that resulted in an increase in the Spin Count Unit. This PR allows the ability to hardcode that value.
Testing
Tested manually and verified by a customer that the fix reverted the regression.
Risk
Low. The setting is not enabled by default and has to be explicitly set by the user for the conditional logic to work.