JIT: Add an in-release flag to enable physical promotion #84689
Conversation
Allow customers to enable this and also to be able to measure TP in the pass.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsAllow customers to enable this and also to be able to measure TP in the pass.
|
|
Example diffs that now show TP (the last one that was triggered with cc @dotnet/jit-contrib PTAL @AndyAyersMS |
| @@ -20,7 +20,7 @@ PhaseStatus Compiler::PhysicalPromotion() | |||
| return PhaseStatus::MODIFIED_NOTHING; | |||
| } | |||
|
|
|||
| if (!compStressCompile(STRESS_PHYSICAL_PROMOTION, 25)) | |||
| if ((JitConfig.JitEnablePhysicalPromotion() == 0) && !compStressCompile(STRESS_PHYSICAL_PROMOTION, 25)) | |||
There was a problem hiding this comment.
Should this be || instead or do we want to do physical promotion if JitEnablePhysicalPromotion == 1 and !compStressCompile(STRESS_PHYSICAL_PROMOTION, 25) is true?
There was a problem hiding this comment.
It should be && -- I want to allow it to be enabled by either JitEnablePhysicalPromotion=1 or the stress mode. compStressCompile is always false in release builds
Allow customers to enable this and also to be able to measure TP in the pass.