Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes for consecutive registers found with jitstressregs #84824

Merged
merged 12 commits into from
Apr 20, 2023

Commits on Apr 14, 2023

  1. Configuration menu
    Copy the full SHA
    1462dc7 View commit details
    Browse the repository at this point in the history
  2. Introduce isLiveAtConsecutiveRegistersLoc and fix dotnet#84747

    This method will track if the defs/uses are live at the same location as
    where the consecutive registers were allocated. If yes, it will skip the
    constraint imposition on it during JitStressRegs
    kunalspathak committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    0d740b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Handle tracking of previously assigned register for copyReg

    When we have copyReg that was just restored or previously assigned
    to a different register, also track it as live at the location so
    it doesn't get allocated again for different refposition at the same
    location.
    kunalspathak committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    89d39b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Configuration menu
    Copy the full SHA
    27ddde6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2cb1937 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    adacdcf View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Update the comments

    kunalspathak committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    092a72c View commit details
    Browse the repository at this point in the history
  2. Stop stresslimiting registerAssignment and instead limit the free reg…

    …isters
    
    Under JitStressRegs, there are multiple ways in which consecutive registers demand
    cannot be met. So skip restricting the registers for `registerAssignment` of a refPosition
    (which are allowable candidates that can be assigned to the given refposition). Instead
    limit the free registers to alternate under stress mode, so we can verify the code if it
    can handle situation where it needs to pick from a mix of free/busy registers.
    kunalspathak committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    77ccc27 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f9cf985 View commit details
    Browse the repository at this point in the history
  4. Update comment

    kunalspathak committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    d2960c6 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. misc. changes

    kunalspathak committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ab5a9c9 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. review feedback

    kunalspathak committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3e1ec41 View commit details
    Browse the repository at this point in the history