Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser][non-icu] HybridGlobalization update string decoding for comparison #85098

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Apr 20, 2023

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

Speeds up the decoding process:

measurement time without this PR [ms] time with this PR [ms] time ICU4C [ms] increase vs ICU [times]
String, String Compare 5.0290 0.2381 0.0448 5,3
String, String Equals 4.9587 0.1886 0.0450 4,19
String, CompareInfo Compare 4.9238 0.1957 0.0451 4,33

Change case needs encoding implementation which is more complex, so the update was limited to compare for now.

@ilonatommy ilonatommy self-assigned this Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Implements a chunk of web-api based globalization. Is a part of HybridGlobalization feature and contributes to #79989.

Speeds up the decoding process:

measurement time without this PR time with this PR
String, String Compare 5.0290ms 0.2381ms
String, String Equals 4.9587ms 0.1886ms
String, CompareInfo Compare 4.9238ms 0.1957ms

Change case needs encoding implementation which is more complex, so the update was limited to compare for now.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization

Milestone: -

@ilonatommy ilonatommy removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Apr 21, 2023
@ilonatommy ilonatommy merged commit 8f517af into dotnet:main Apr 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants