-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable StripSymbols
by default
#85139
Conversation
See discussion in dotnet/sdk#31739 (comment). Once this merges, we should: - [ ] Update the `dotnet new console -aot` template - [ ] Update the `dotnet new api -aot` template - [ ] Update docs and declare different defaults.
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSee discussion in dotnet/sdk#31739 (comment). Once this merges, we should:
Cc @dotnet/ilc-contrib @am11 @DamianEdwards @eerhardt
|
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Cc @kotlarmilos @akoeplinger looks like there's an issue with the GenerateUnmanagedEntrypoints test when stripsymbols is specified. A wild guess is that this strips the symbols we actually need. Don't have a mac around to investigate. I'm going to enable StripSymbols on the test on mac so that we don't block this since GenerateUnmanagedEntrypoints is not an end user scenario.
|
/azp run runtime-extra-platforms |
Azure Pipelines successfully started running 1 pipeline(s). |
I can look into this, as I added the test case. |
@ivanpovazan Thanks! Let me know if the failure is caused by particular stripping options introduced in #81361. |
See discussion in dotnet/sdk#31739 (comment).
Once this merges, we should:
dotnet new console -aot
templatedotnet new api -aot
templateCc @dotnet/ilc-contrib @am11 @DamianEdwards @eerhardt