[mono][jit] Add Vector128.WithElement as intrinsic on arm64. #85158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2049
to
+2052
| if (index < 0 || index >= elems) { | ||
| MONO_EMIT_NEW_BIALU_IMM (cfg, OP_COMPARE_IMM, -1, args [1]->dreg, elems); | ||
| MONO_EMIT_NEW_COND_EXC (cfg, GE_UN, "ArgumentOutOfRangeException"); | ||
| } |
There was a problem hiding this comment.
Is the comparison needed here since we know the exception is deterministically going to happen?
There was a problem hiding this comment.
That's a good point. I'll make this an unconditional throw.
There was a problem hiding this comment.
It seems we do not have an opcode to unconditionally throw an exception. IMO adding it would be out of this PR's scope. Having the comparison in place should not hurt the normal execution path. So I propose adding an issue for the new opcode and deferring this optimization until it is in place. Are you OK with that? @tannergooding @vargaz
tannergooding
approved these changes
Apr 21, 2023
This was referenced Apr 21, 2023
vargaz
approved these changes
Apr 21, 2023
|
CI failures are known issues and unrelated to this PR. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
Vector128.WithElementintrinsic and lowers it as follows or arm64:indexis a constant and in range, emits onemovand oneinsand omits a bound checkindexis a constant and out of range, does the same as above but includes a bounds checkTis 64-bit, emits a conditional branch that selects one of twoins(for lower or upper half) and includes a bounds check. A maximum of 5 instructions are emitted.The last case is not very efficient; however given that the case should be uncommon, it is probably not a big issue.
Contributes to #80566