Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize >>> to ShiftRightLogical on arm64 #85258

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Apr 24, 2023

Closes #85257

XARCH is already doing the same.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 24, 2023
@ghost ghost assigned EgorBo Apr 24, 2023
@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #85257

XARCH is already doing the same.

Author: EgorBo
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@MihaZupan
Copy link
Member

That was fast 😄

@EgorBo
Copy link
Member Author

EgorBo commented Apr 24, 2023

Diffs. @tannergooding PTAL, this PR copies XArch behavior for these.

@EgorBo EgorBo requested a review from tannergooding April 24, 2023 19:16
@EgorBo EgorBo merged commit 48b5311 into dotnet:main Apr 24, 2023
@EgorBo EgorBo deleted the fix-arm64-shift-right branch April 24, 2023 19:36
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JIT isn't optimizing >>> in the same way as Vector128.ShiftRightLogical on ARM
4 participants