Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] Add Android BenchmarkDotNet test #85282

Merged
merged 13 commits into from
Apr 27, 2023

Conversation

LoopedBard3
Copy link
Member

This is the PR for the runtime repo to add Android BDN testing to the perf teams lab. It includes a build yml script, the addition of the tests to the android_scenarios.proj file, and the piping of the built APK through to the helix workload.

Testing changes are still present in perf-non-wasm-jobs.yml and perf.yml, and will be removed after test run for just the BDN app is complete.

Shift perflab dependencies to the app build through insertion rather than being in the Maui repo.
Add PERFLAB_INLAB preprocessor constant to include the environment variables section of the Maui app in the build.
Switch to using the main branch of the perf repo.
Hardcoded in the output path to avoid unused variable error when building the Maui App.
… as a property was overwritting all the other constants set (they are used a lot).
@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This is the PR for the runtime repo to add Android BDN testing to the perf teams lab. It includes a build yml script, the addition of the tests to the android_scenarios.proj file, and the piping of the built APK through to the helix workload.

Testing changes are still present in perf-non-wasm-jobs.yml and perf.yml, and will be removed after test run for just the BDN app is complete.

Author: LoopedBard3
Assignees: LoopedBard3
Labels:

area-Infrastructure

Milestone: -


- script: |
echo '{ }' > ./global.json
curl -o NuGet.config 'https://raw.githubusercontent.com/dotnet/maui/net8.0/NuGet.config'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the net8.0 here and below be parametrized? Future-proofing us...

@LoopedBard3
Copy link
Member Author

@LoopedBard3
Copy link
Member Author

@LoopedBard3
Copy link
Member Author

Any failures are unrelated as this doesn't make any changes to non-perf infrastructure, merging.

@LoopedBard3 LoopedBard3 merged commit 92ba066 into dotnet:main Apr 27, 2023
@LoopedBard3 LoopedBard3 deleted the PerfAddAndroidBDNTesting branch April 28, 2023 19:22
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants