-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add introspection for readelf #85298
Conversation
Tagging subscribers to this area: @tommcdon Issue Detailsnull
|
Tagging subscribers to this area: @hoyosjs Issue Detailsnull
|
b037af4
to
86e5350
Compare
Thank you. You fixed errors in other archs like the one below
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Mono failures are unrelated / known failures according to build analysis. |
All issues are known |
Just like
CMAKE_NM
, which is used byverify-entrypoints.sh
, introspectCMAKE_READELF
forgenmoduleindex.sh
.I saw some warnings in riscv64 logs in @clamp03's PR #85289. Those warnings are reported by binutils readelf, which doesn't seem to handle DWARF 5 very well:
With this change, the script uses
llvm-readelf-15
in that container (matching the exact toolchain in use) and reports no warning.Also removed the usage of
eval
in the script while I was at it.