Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Base64 value length limit from Utf8JsonWriter #85334

Merged
merged 3 commits into from
Apr 28, 2023

Conversation

stephentoub
Copy link
Member

Closes #39953 (unless we want to use it to track removing the other limits)

@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #39953 (unless we want to use it to track removing the other limits)

Author: stephentoub
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@stephentoub
Copy link
Member Author

@eiriktsarpalis, other than your feedback about going further and removing additional limits (which I agree with but would like to see done separately), does this look ok?

@stephentoub stephentoub merged commit 00460e0 into dotnet:main Apr 28, 2023
@stephentoub stephentoub deleted the removebase64limit branch April 28, 2023 18:50
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The JSON value of length n is too large and not supported #2
2 participants