Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix physical promotion scenario name and a couple of bugs #85343

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Fix physical promotion scenario name and a couple of bugs #85343

merged 3 commits into from
Apr 26, 2023

Conversation

jakobbotsch
Copy link
Member

@jakobbotsch jakobbotsch commented Apr 25, 2023 •
edited
Loading

This was renamed but I forgot to update these occurrences. The result is that runtime-jit-experimental is not actually running with physical promotion enabled (but the stress jobs do).

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Fix #85403

@jakobbotsch
Fix generalized promotion scenario name
d7b4ca7 
This was renamed but I forgot to update these occurrences. The result is
that runtime-jit-experimental is not actually running with physical
promotion enabled.
@ghost ghost assigned jakobbotsch Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This was renamed but I forgot to update these occurrences. The result is that runtime-jit-experimental is not actually running with physical promotion enabled (but the stress jobs do).

cc @dotnet/jit-contrib PTAL @AndyAyersMS

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-Infrastructure-coreclr
Milestone: -

@jakobbotsch jakobbotsch requested a review from AndyAyersMS April 25, 2023 17:39
BruceForstall
BruceForstall approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like testenvironment.proj should loudly fail if the scenario name isn't found

@jkoritzinsky
Copy link
Member

Seems like testenvironment.proj should loudly fail if the scenario name isn't found

One possible solution for this would be to change testenvironment.proj to use pre-written .env files instead of generating environment scripts on the fly. That way we'd be able to be able to easily tell when a scenario isn't known as there wouldn't be a file on disk for the scenario.

@jakobbotsch
Copy link
Member Author

Failures look known according to build analysis.

@jakobbotsch
Copy link
Member Author

/azp run runtime-jit-experimental

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 25, 2023
Closed
Closed
Open
Closed
@jakobbotsch jakobbotsch changed the title Fix physical promotion scenario name Fix physical promotion scenario name and a couple of bugs Apr 26, 2023
@jakobbotsch
Copy link
Member Author

/azp run runtime-jit-experimental, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jakobbotsch
Copy link
Member Author

runtime-jit-experimental and recent jitstress runs seem to be hitting some problems I fixed in #85323, so I I ported a couple of fixes from there to this PR.

@jakobbotsch
Copy link
Member Author

/azp run runtime-jit-experimental, runtime-coreclr jitstress, runtime-coreclr libraries-jitstress

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jakobbotsch jakobbotsch mentioned this pull request Apr 26, 2023
Closed
@jakobbotsch
Copy link
Member Author

The remaining stress failures should have been fixed with #85396, but not sure what is going on with the OSX runs.

@MichalPetryka
Copy link
Contributor

but not sure what is going on with the OSX runs.

OSX runner seems to be having issues right now, it timed out on my PR.

@MichalPetryka MichalPetryka mentioned this pull request Apr 26, 2023
Merged
@jakobbotsch
Copy link
Member Author

It looks like there's still some libraries-jitstress failures; opened #85426 for it (doesn't look related to physical promotion).

@jakobbotsch jakobbotsch merged commit 2430618 into dotnet:main Apr 26, 2023
@jakobbotsch jakobbotsch deleted the fix-physical-promotion-scenario branch April 26, 2023 22:43
@build-analysis build-analysis bot mentioned this pull request Apr 26, 2023
Closed
This was referenced Apr 27, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BruceForstall BruceForstall BruceForstall approved these changes

@tannergooding tannergooding tannergooding approved these changes

@AndyAyersMS AndyAyersMS Awaiting requested review from AndyAyersMS

Assignees

@jakobbotsch jakobbotsch

Labels
area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[jitstress] Assertion failed 'replacements[firstIndex].Overlaps(offs, size)' during 'Physical promotion'
5 participants
@jakobbotsch @jkoritzinsky @MichalPetryka @tannergooding @BruceForstall