Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few downlevel TimeProvider issues #85346

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Fix a few downlevel TimeProvider issues #85346

merged 1 commit into from
Apr 25, 2023

Conversation

stephentoub
Copy link
Member

  • Consistently null check the Timer stored in the state object
  • Complete the a task canceled due to the CancellationToken with the CancellationToken
  • Avoid an unnecessary closure in Delay
  • Make TimeProvider.System.CreateTimer use Timer's ctor that takes duration/period rather than making a separate call to Change

@stephentoub
Fix a few downlevel TimeProvider issues
566c00a 
- Consistently null check the Timer stored in the state object
- Complete the a task canceled due to the CancellationToken with the CancellationToken
- Avoid an unnecessary closure in Delay
- Make TimeProvider.System.CreateTimer use Timer's ctor that takes duration/period rather than making a separate call to Change
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 25, 2023
@ghost ghost assigned stephentoub Apr 25, 2023
@tarekgh tarekgh added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 25, 2023
@tarekgh tarekgh added this to the 8.0.0 milestone Apr 25, 2023
@ghost
Copy link

ghost commented Apr 25, 2023

Tagging subscribers to this area: @dotnet/area-system-datetime
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Consistently null check the Timer stored in the state object
  • Complete the a task canceled due to the CancellationToken with the CancellationToken
  • Avoid an unnecessary closure in Delay
  • Make TimeProvider.System.CreateTimer use Timer's ctor that takes duration/period rather than making a separate call to Change
Author: stephentoub
Assignees: stephentoub
Labels:

area-System.DateTime
Milestone: -

@stephentoub stephentoub merged commit 45e6aed into dotnet:main Apr 25, 2023
@stephentoub stephentoub deleted the fixtp branch April 25, 2023 21:59
This was referenced Apr 25, 2023
Closed
Closed
Open
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@sebastienros sebastienros sebastienros approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.DateTime
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @sebastienros @tarekgh