Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NodeJS] Enable wasm exception handling for unit tests #85387

Merged
merged 1 commit into from
Apr 26, 2023
Merged

[NodeJS] Enable wasm exception handling for unit tests #85387

merged 1 commit into from
Apr 26, 2023

Conversation

pavelsavara
Copy link
Member

In order to fix Log

CompileError: WebAssembly.instantiate(): unexpected section <Tag> (enable with --experimental-wasm-eh) @+16822

@radekdoulik do we need to do something about console host and the template too ?

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture wasm-aot-test WebAssembly AOT Test labels Apr 26, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Apr 26, 2023
@pavelsavara pavelsavara self-assigned this Apr 26, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In order to fix Log

CompileError: WebAssembly.instantiate(): unexpected section <Tag> (enable with --experimental-wasm-eh) @+16822

@radekdoulik do we need to do something about console host and the template too ?

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, wasm-aot-test
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara added area-Build-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 26, 2023
@pavelsavara
Copy link
Member Author

pavelsavara commented Apr 26, 2023 •
edited
Loading

This is log after this fix where the same test passed.

Other failures are unrelated.

@pavelsavara pavelsavara marked this pull request as ready for review April 26, 2023 12:23
radekdoulik
radekdoulik approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radekdoulik
Copy link
Member

@radekdoulik do we need to do something about console host and the template too ?

I think we already handle it here https://github.com/dotnet/runtime/blob/main/src/mono/wasm/templates/templates/console/runtimeconfig.template.json#L10

@pavelsavara pavelsavara merged commit 342c4ed into dotnet:main Apr 26, 2023
This was referenced Apr 26, 2023
Closed
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
@pavelsavara pavelsavara deleted the nodejs_enable_eh branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radekdoulik radekdoulik radekdoulik approved these changes

@lewing lewing Awaiting requested review from lewing

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Build-mono wasm-aot-test WebAssembly AOT Test
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @radekdoulik