-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _MergedWrapperMarker to not include markers without corresponding execution scripts #85476
Fix _MergedWrapperMarker to not include markers without corresponding execution scripts #85476
Conversation
Don't include markers without execution scripts
/azp run runtime-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @hoyosjs Issue DetailsDon't include markers without execution scripts
|
This is a slight fix to #85441 |
I verified that the only groups missing from a Pri-0 Linux-x64 test run now are: HardwareIntrinsics_Arm_r which is what we want, since they were the ones failing before. |
Failure in outerloop is #85081 (which is supposed to be disabled). |
I've a question I left in a comment, but otherwise it LGTM! Thanks for fixing this Bruce |
fwiw, on a linux-x64 dev box you might build using:
But on the CI, the build process is more like this (with many things happening on separate machines):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for landing the real fix Bruce!
Don't include markers without execution scripts