Code

Intrinsics analyzer and fixes#85481

Code

Merged

davidwrighton merged 21 commits intodotnet:maindotnet/runtime:mainfrom davidwrighton:IntrinsicsAnalyzerAndFixesdavidwrighton/runtime:IntrinsicsAnalyzerAndFixesCopy head branch name to clipboardMay 16, 2023

+2,399-227

Commits

Commits on Apr 26, 2023

• Implement analyzer for platform intrinsics use in System.Private.CoreLib

  Show description for e1f2f17
  davidwrighton

  committed
  e1f2f17

  Copy full SHA for e1f2f17

• Remove BypassReadyToRunAttribute as it should no longer be needed for intrinsics usages

  davidwrighton

  committed
  b246bd0

  Copy full SHA for b246bd0

Commits on Apr 27, 2023

• Document new intrinsic handling behavior and enhance crossgen2 to respect the new attribute

  davidwrighton

  committed
  35105fb

  Copy full SHA for 35105fb

• Fix build break

  davidwrighton

  committed
  59a55e4

  Copy full SHA for 59a55e4

Commits on Apr 28, 2023

• Fix condition noted in code review

  davidwrighton

  committed
  768d1a9

  Copy full SHA for 768d1a9

Commits on May 9, 2023

• Update analyzer to detect more patterns, and attribute much of System.Private.CoreLib

  davidwrighton

  committed
  5ac974c

  Copy full SHA for 5ac974c

• Add pragmas and attributes to the packed span helpers

  Show description for cdc8b3f
  davidwrighton

  committed
  cdc8b3f

  Copy full SHA for cdc8b3f

• Hah! It works

  Show description for a01fd9d
  davidwrighton

  committed
  a01fd9d

  Copy full SHA for a01fd9d

• Rename attribute and fix docs

  davidwrighton

  committed
  5573738

  Copy full SHA for 5573738

• Merge branch 'main' of github.com:dotnet/runtime into IntrinsicsAnalyzerAndFixes

  davidwrighton

  committed
  5134b86

  Copy full SHA for 5134b86

• Add analyzer tests and fixup issues from merging with main branch

  davidwrighton

  committed
  506f053

  Copy full SHA for 506f053

• Disable tests on Mono due to Mono runtime bug

  davidwrighton

  committed
  2e33ae4

  Copy full SHA for 2e33ae4

Commits on May 10, 2023

• Handle incorrect namespace for the CompExactlyDependsOnAttribute and don't pass a null InstructionSetSupport into the ShouldSkipCompilation logic, just feed it around everywhere.

  davidwrighton

  committed
  8a69798

  Copy full SHA for 8a69798

Commits on May 15, 2023

• Merge branch 'main' of github.com:dotnet/runtime into IntrinsicsAnalyzerAndFixes

  davidwrighton

  committed
  919e0c3

  Copy full SHA for 919e0c3

• With the analyzer, negative checks are problematic, so re-order some of them. Also we needed some new pragma warning disables to make the new logic work

  davidwrighton

  committed
  4e413bd

  Copy full SHA for 4e413bd

• Code review feedback

  davidwrighton

  committed
  994ff3e

  Copy full SHA for 994ff3e

• Update src/coreclr/tools/aot/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs

  Show description for 8ed51a1
  

  davidwrighton

  and

  jkoritzinsky

  authored
  8ed51a1

  Copy full SHA for 8ed51a1

• Update src/libraries/System.Private.CoreLib/tests/IntrinsicsInSystemPrivatecoreLibAnalyzer.Tests/IntrinsicsInSystemPrivateCoreLib.Tests.csproj

  Show description for 9442ebe
  

  davidwrighton

  and

  jkoritzinsky

  authored
  9442ebe

  Copy full SHA for 9442ebe

• Update src/libraries/System.Private.CoreLib/gen/IntrinsicsInSystemPrivateCoreLibAnalyzer.cs

  Show description for fba92eb
  

  davidwrighton

  and

  jkoritzinsky

  authored
  fba92eb

  Copy full SHA for fba92eb

• Update IntrinsicsInSystemPrivateCoreLibAnalyzer.cs

  davidwrighton

  authored
  fcc38ca

  Copy full SHA for fcc38ca

• Use auto-implemented get-only property

  davidwrighton

  committed
  62c5e58

  Copy full SHA for 62c5e58