Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Unify boot config location #85763

Merged
merged 11 commits into from
May 12, 2023
Merged

[wasm] Unify boot config location #85763

merged 11 commits into from
May 12, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented May 4, 2023 •
edited
Loading

  • We need both mono-config.json and blazor.boot.json schemas until we can use new SDK in tree
  • Rename mono-config to blazor.boot.json to unify location where to load config from
  • Drop the need for withStartupOptions to use Wasm SDK path in JS

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels May 4, 2023
@maraf maraf added this to the 8.0.0 milestone May 4, 2023
@maraf maraf self-assigned this May 4, 2023
@ghost
Copy link

ghost commented May 4, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • We need both mono-config.json and blazor.boot.json schemas until we can use new SDK in tree
  • Rename mono-config to blazor.boot.json to unify location where to load config from
  • Drops the need for withStartupOptions to use Wasm SDK
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

@pavelsavara
Copy link
Member

This would be ugly merge, other than that look like acceptable temporary solution.

#85730

@maraf
Copy link
Member Author

maraf commented May 4, 2023

I can easily redo it after loader. Mostly text replaces

@build-analysis build-analysis bot mentioned this pull request May 5, 2023
Closed
pavelsavara
pavelsavara reviewed May 12, 2023
View reviewed changes
src/mono/wasm/runtime/blazor/BootConfig.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/blazor/_Integration.ts Outdated Show resolved Hide resolved
src/mono/wasm/runtime/loader/config.ts Show resolved Hide resolved
src/mono/wasm/runtime/loader/run.ts Show resolved Hide resolved
@maraf maraf merged commit a91d781 into dotnet:main May 12, 2023
@maraf maraf deleted the WasmUnifyConfigLocatioon branch May 12, 2023 17:52
This was referenced May 15, 2023
Merged
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@maraf @pavelsavara