Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono][aot] Fix an assert. #86054

Merged
merged 1 commit into from
May 10, 2023
Merged

[mono][aot] Fix an assert. #86054

merged 1 commit into from
May 10, 2023

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented May 10, 2023

Fixes #86052.

@radical
Copy link
Member

radical commented May 10, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented May 10, 2023

WBT failing with:

  [System.Private.CoreLib.dll] Exec (with response file contents expanded) in /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in: MONO_PATH=/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in:/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/8.0.0-ci/runtimes/browser-wasm/native/:/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.Mono.browser-wasm/8.0.0-ci/runtimes/browser-wasm//lib/net8.0 MONO_ENV_OPTIONS= /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm/8.0.0-ci/Sdk/../tools/mono-aot-cross --wasm-exceptions --debug --llvm "--aot=no-opt,static,direct-icalls,deterministic,mattr=simd,dwarfdebug,llvm-path=/root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.Emscripten.3.1.34.Sdk.linux-x64/8.0.0-preview.5.23252.1/tools/bin/,static,dedup-skip,llvmonly,interp,asmonly,llvm-outfile=/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/System.Private.CoreLib.dll.bc.tmp" "System.Private.CoreLib.dll"
  
Precompiling failed for /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in/System.Private.CoreLib.dll with exit code 134. [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]
Mono Ahead of Time compiler - compiling assembly /root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/obj/Debug/net8.0/wasm/for-publish/aot-in/System.Private.CoreLib.dll [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]
* Assertion at /__w/1/s/src/mono/mono/mini/aot-compiler.c:10276, condition `info->subtype == WRAPPER_SUBTYPE_NONE || info->subtype == WRAPPER_SUBTYPE_PINVOKE' not met [/root/helix/work/workitem/e/wbt/blazorwasm_Debug_aot_3yecgsan.jot/blazorwasm_Debug_aot_3yecgsan.jot.csproj]

@vargaz vargaz force-pushed the fix-aot-assert2 branch from 59062b3 to c411c46 Compare May 10, 2023 19:02
@vargaz
Copy link
Contributor Author

vargaz commented May 10, 2023

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented May 10, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented May 10, 2023

Runtime-wasm-perf failures are unrelated.

@lewing lewing merged commit 0b5f137 into dotnet:main May 10, 2023
@vargaz vargaz deleted the fix-aot-assert2 branch May 11, 2023 00:17
@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] AOT perf runs, and library tests are failing due to src/mono/mono/mini/aot-compiler.c:10110
3 participants