Remove System.Reflection wrappers from the STJ source generator. #86334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
May 16, 2023
| /// <summary> | ||
| /// Traverses a DAG and returns its nodes applying topological sorting to the result. | ||
| /// </summary> | ||
| public static T[] TraverseGraphWithTopologicalSort<T>(T entryNode, Func<T, ICollection<T>> getChildren, IEqualityComparer<T>? comparer = null) |
There was a problem hiding this comment.
Replaces the algorithm now deleted from ReflectionExtensions.cs to one that better works for both Symbol and Type instances.
eiriktsarpalis
commented
May 16, 2023
stephentoub
reviewed
May 16, 2023
layomia
reviewed
May 17, 2023
|
The plan is to remove |
|
Yes, the PR should be removing all the classes that make this abstraction possible. |
layomia
reviewed
May 17, 2023
src/libraries/System.Text.Json/gen/System.Text.Json.SourceGeneration.targets
Outdated
Show resolved
Hide resolved
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
....Json/tests/System.Text.Json.SourceGeneration.Tests/Serialization/PropertyVisibilityTests.cs
Show resolved
Hide resolved
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
layomia
reviewed
May 17, 2023
...on/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorIncrementalTests.cs
Show resolved
Hide resolved
layomia
reviewed
May 17, 2023
...tem.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/JsonSourceGeneratorTests.cs
Show resolved
Hide resolved
layomia
reviewed
May 17, 2023
...ries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/TypeWrapperTests.cs
Show resolved
Hide resolved
layomia
approved these changes
May 17, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #79533.
Contributes to #68353.