-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku: Configuration support #86391
Haiku: Configuration support #86391
Conversation
8b9fb18
to
af97252
Compare
The mono changes look ok. |
af97252
to
79b7330
Compare
79b7330
to
3b981e8
Compare
3b981e8
to
2c315d5
Compare
2c315d5
to
e8d4f3c
Compare
Tagging subscribers to this area: @hoyosjs Issue DetailsAdded more support for configuration for Haiku cross-compile builds. This commit adds recognition for Haiku as a supported platform in various build and configuration files. For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the Part of #55803.
|
e8d4f3c
to
75f5797
Compare
75f5797
to
9195830
Compare
9195830
to
3012760
Compare
91e7d16
to
98090da
Compare
98090da
to
222bc8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
222bc8e
to
3698fb8
Compare
3698fb8
to
e5ba96e
Compare
e5ba96e
to
a0efe97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Any concerns with getting this PR merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libraries changes look good to me. I would like to change the four touched projects (Net.Http, Net.NetworkInformation, Net.Security and Serialization.Formatters) in the future so that we don't have to introduce new platform TFMs.
@trungnt2910 Could you please resolve the conflict? |
Added more support for configuration for Haiku cross-compile builds.
a0efe97
to
7338ea4
Compare
Done. |
@trungnt2910 Thank you! |
Added more support for configuration for Haiku cross-compile builds.
This commit adds recognition for Haiku as a supported platform in various build and configuration files.
For CMake files, this change adds additional guards for non-POSIX headers, functions, and struct members, most notably the
<ucontext.h>
header. (According to the latest POSIX standard,ucontext_t
should be defined in<signal.h>
, while<ucontext.h>
is no longer mandated).-ldl
is also replaced with${CMAKE_DL_LIBS}
since Haiku does not havelibdl
.Part of #55803.