[NativeAOT] Fix MD array GC series #86877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Detailsneed to figure how to make a test for this
|
VSadov
commented
May 29, 2023
| @@ -550,7 +550,7 @@ private static unsafe int CreateArrayGCDesc(LowLevelList<bool> bitfield, int ran | |||
| { | |||
| if (numSeries > 0) | |||
| { | |||
| *ptr-- = (short)((bitfield.Count - last + baseOffset - 2) * IntPtr.Size); | |||
| *ptr-- = (short)((i - last) * IntPtr.Size); | |||
There was a problem hiding this comment.
baseOffset is not a factor in computing the last "skip" in a GC series element. It should be just
the end of the element - offset of the last GC pointer.
For SZ arrays the baseOffset is 2, so adding baseOffset - 2 was harmless.
In MD array it results in incorrect "skip".
jkotas
reviewed
May 30, 2023
...coreclr/nativeaot/System.Private.TypeLoader/src/Internal/Runtime/TypeLoader/EETypeCreator.cs
Outdated
Show resolved
Hide resolved
…untime/TypeLoader/EETypeCreator.cs Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was triggering GC asserts and test failures in a side project.
turns out it s not GC’s fault