Use Knobs to populate AppContext switches #86883
Conversation
Previously AppContext switches were set by injecting a method that calls `AppContext.SetSwitch` at startup. Use the configuration blob added in dotnet#86068 instead. This makes startup a tiny bit faster and the outputs a tiny bit smaller. Fixes dotnet#77054.
ghost
assigned 
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsPreviously AppContext switches were set by injecting a method that calls Fixes #77054. Cc @dotnet/ilc-contrib
|
| @@ -204,19 +239,19 @@ void RhConfig::ReadEmbeddedSettings(void *volatile * embeddedSettings, void* com | |||
| { | |||
| if (*embeddedSettings == NULL) | |||
| { | |||
| uint32_t size = ((CompilerEmbeddedSettingsBlob*)compilerEmbeddedSettingsBlob)->Size; | |||
| uint32_t count = ((CompilerEmbeddedSettingsBlob*)compilerEmbeddedSettingsBlob)->Count; | |||
There was a problem hiding this comment.
We're treating the size as count incorrectly in rest of the code (missed that in the code review). So this is also a bugfix.
There was a problem hiding this comment.
Ended up deleting all of this.
It ran into an issue that we had a hard limit on how long a key or value can be and instead of writing more C code, I just deleted it and update the compiler to emit it in a format that we don't need to parse at all and just use as-is.
The less string handling code in C we have to maintain, the better.
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/coreclr/nativeaot/System.Private.CoreLib/src/System/AppContext.NativeAot.cs
Outdated
Show resolved
Hide resolved
Previously AppContext switches were set by injecting a method that calls
AppContext.SetSwitchat startup. Use the configuration blob added in #86068 instead. This makes startup a tiny bit faster and the outputs a tiny bit smaller.Fixes #77054.
Cc @dotnet/ilc-contrib