Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][debugging] Enable debugging when Device Toolbar is enabled and Iphone is selected #86920

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented May 30, 2023

When DevTools is enabled and iPhone 12 is selected, navigatorUA.userAgentData.brands has length = 0 and Debugger was disabled.
With this PR is possible to debug when Device iPhone is selected.
image

Fixes:
#84171 (comment)

@ghost
Copy link

ghost commented May 30, 2023

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

When DevTools is enabled and iPhone 12 is selected, navigatorUA.userAgentData.brands has length = 0 and Debugger was disabled.
With this PR is possible to debug when Device iPhone is selected.
image

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label May 31, 2023
@ghost
Copy link

ghost commented May 31, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

When DevTools is enabled and iPhone 12 is selected, navigatorUA.userAgentData.brands has length = 0 and Debugger was disabled.
With this PR is possible to debug when Device iPhone is selected.
image

Fixes:
#84171 (comment)

Author: thaystg
Assignees: thaystg
Labels:

arch-wasm, area-Debugger-mono

Milestone: -

@pavelsavara pavelsavara added this to the 8.0.0 milestone May 31, 2023
@pavelsavara
Copy link
Member

We have similar test in src\mono\wasm\runtime\scheduling.ts which uses it to prevent CPU throttling. Could you please also fix that or unify it.

@thaystg
Copy link
Member Author

thaystg commented May 31, 2023

scheduling.ts

As discussed with you, you will work on it.


let node_fs: any | undefined = undefined;
let node_url: any | undefined = undefined;

export async function init_polyfills(module: DotnetModuleInternal): Promise<void> {
export async function detect_features_and_polyfill(module: DotnetModuleInternal): Promise<void> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kg we could start adding more feature detection here on next PRs, like SIMD, MT etc

@pavelsavara pavelsavara closed this Jun 8, 2023
@pavelsavara pavelsavara reopened this Jun 8, 2023
@pavelsavara
Copy link
Member

image

@pavelsavara pavelsavara merged commit 03f2be6 into dotnet:main Jun 8, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants