Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Fix fingerprinting of relinked dotnet.js - follow up #87051

Merged
merged 9 commits into from
Jun 8, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented Jun 2, 2023

Address comments from #86048

  • More relaxed regex to check files are fingerprinted
  • Test turning on fingerprinting
  • Use ResolvedRuntimePack to get runtime pack version

@maraf maraf added this to the 8.0.0 milestone Jun 2, 2023
@maraf maraf requested review from radical and lewing as code owners June 2, 2023 11:28
@maraf maraf self-assigned this Jun 2, 2023
@maraf maraf added the arch-wasm WebAssembly architecture label Jun 2, 2023
@ghost
Copy link

ghost commented Jun 2, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Address comments from #86048

  • More relaxed regex to check files are fingerprinted
  • Test .NET 7.0 fingerprinting
  • Use ResolvedRuntimePack to get runtime pack version
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono

Milestone: 8.0.0

@maraf maraf closed this Jun 8, 2023
@maraf maraf reopened this Jun 8, 2023
@maraf maraf merged commit 5ebb520 into dotnet:main Jun 8, 2023
@maraf maraf deleted the WasmFingerprintFollowUp branch June 8, 2023 11:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants