-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzers and code-fixes to help adoption of source-generated COM #87223
Merged
jkoritzinsky
merged 21 commits into
dotnet:main
from
jkoritzinsky:com-migration-analyzer
Jun 9, 2023
Merged
Add analyzers and code-fixes to help adoption of source-generated COM #87223
jkoritzinsky
merged 21 commits into
dotnet:main
from
jkoritzinsky:com-migration-analyzer
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd add tests for the various other analyzers we are going to introduce.
…n share it with the ComInterfaceGenerator-family of fixers.
…PIs instead of dropping to C#-specific syntax APIs (improves consistency throughout our code fixes)
…tToSourceGeneratedInteropFixer base type.
… of delegates" model.
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #86343 Also refactors a base class for our code-fixes to use that handles providing fix-all support and "enable allow unsafe blocks" support. Interesting aspects here for the analyzer/fixer:
|
This was referenced Jun 7, 2023
jtschuster
approved these changes
Jun 8, 2023
....Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
Show resolved
Hide resolved
....Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
Show resolved
Hide resolved
This was referenced Jun 8, 2023
src/libraries/System.Runtime.InteropServices/gen/Common/ConvertToSourceGeneratedInteropFixer.cs
Outdated
Show resolved
Hide resolved
...gen/ComInterfaceGenerator/Analyzers/ComHostingDoesNotSupportGeneratedComInterfaceAnalyzer.cs
Show resolved
Hide resolved
...Services/gen/ComInterfaceGenerator/Analyzers/ConvertComImportToGeneratedComInterfaceFixer.cs
Outdated
Show resolved
Hide resolved
AaronRobinsonMSFT
approved these changes
Jun 8, 2023
...es/System.Runtime.InteropServices/gen/ComInterfaceGenerator/Analyzers/AnalyzerDiagnostics.cs
Show resolved
Hide resolved
…ext. Update diagnostics list md.
Test failures are all known. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86343
Also refactors a base class for our code-fixes to use that handles providing fix-all support and "enable allow unsafe blocks" support.
Interesting aspects here for the analyzer/fixer:
new
keyword. We can try to make this smarter (validate members against base class, etc).EnableComHosting
property from MSBuild to Roslyn.