Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Fix perf pipeline #87469

Merged
merged 4 commits into from
Jun 13, 2023
Merged

[wasm] Fix perf pipeline #87469

merged 4 commits into from
Jun 13, 2023

Conversation

radical
Copy link
Member

@radical radical commented Jun 13, 2023 •
edited
Loading

  • [wasm] Use the current test-main.js instead of the one for 7.0
  • [wasm] perf: Add --module arg for v8, to support the es6 module
  • [wasm] perf: Use tar for BrowserWasm for perf runs
  • disable non-wasm builds

Fixes #87434

@radical radical added the arch-wasm WebAssembly architecture label Jun 13, 2023
@ghost ghost assigned radical Jun 13, 2023
@ghost
Copy link

ghost commented Jun 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • [wasm] Use the current test-main.js instead of the one for 7.0
  • [wasm] perf: Add --module arg for v8, to support the es6 module
  • [wasm] perf: Use tar for BrowserWasm for perf runs
  • disable non-wasm builds
Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical changed the title perf fix main [wasm] Fix perf pipeline Jun 13, 2023
@radical
Copy link
Member Author

radical commented Jun 13, 2023

Waiting on the changes to get tested with dotnet-runtime-perf - 20230612.18.

This was referenced Jun 13, 2023
Closed
Closed
@SamMonoRT
Copy link
Member

/cc @LoopedBard3 @caaavik-msft

@radical radical marked this pull request as ready for review June 13, 2023 19:39
@radical
Copy link
Member Author

radical commented Jun 13, 2023

Waiting on the changes to get tested with dotnet-runtime-perf - 20230612.18.

This passed. I want to merge this PR asap to unblock the perf pipeline.

LoopedBard3
LoopedBard3 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise looks good to me!

eng/pipelines/coreclr/perf-wasm-prepare-artifacts-steps.yml Outdated Show resolved Hide resolved
@radical
Copy link
Member Author

radical commented Jun 13, 2023

None of the changes here will affect the CI checks on the PR itself. They will get instead affect dotnet-runtime-perf. I'm merging this now to unblock the perf pipeline.

@radical radical merged commit bccebe7 into dotnet:main Jun 13, 2023
@radical radical deleted the perf-fix-main branch June 13, 2023 20:05
@ghost ghost locked as resolved and limited conversation to collaborators Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LoopedBard3 LoopedBard3 LoopedBard3 approved these changes

@lewing lewing Awaiting requested review from lewing

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Infrastructure-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm] Perf pipeline completely broken
3 participants
@radical @SamMonoRT @LoopedBard3