Fix jitdump issues introduced by #85801 #87547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
approved these changes
Jun 14, 2023
| @@ -213,9 +213,6 @@ struct PerfJitDumpState | |||
| enabled = true; | |||
|
|
|||
There was a problem hiding this comment.
The one in line 179 is now unnecessary (though it's a no-op.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #85801 I removed the jitdump specific locks in favor of the global perfmap lock, but left the checks that
pthread_mutex_unlockreturned0in place. Result would be the number of bytes written after logging a method and would cause a call toFatalError()and prematurely shut down the jitdump support.