Support config binding ext methods in options assembly #87733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsThat is, intercept calls to methods on With this change, all the expected/common entry points for configuration binding in ASP.NET + AOT scenarios are now covered. cc @eerhardt @DamianEdwards. cc @andrewlock issues with #86348 should be fixed following this PR.
|
layomia
commented
Jun 17, 2023
...icrosoft.Extensions.Configuration.Binder/gen/GeneratedMethods/ConfigBinderMethodSpec.Emit.cs
Outdated
Show resolved
Hide resolved
…her than new method spec types
layomia
force-pushed
the
binder-gen-options
branch
from
e4a4b60 to
cc511b0
Compare
layomia
commented
Jun 19, 2023
...braries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/ConfigurationBinder.cs
Show resolved
Hide resolved
layomia
commented
Jun 19, 2023
...libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Emitter/CoreBindingHelper.cs
Show resolved
Hide resolved
layomia
commented
Jun 19, 2023
...ibraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/Parser/ConfigurationBinder.cs
Show resolved
Hide resolved
...aries/Microsoft.Extensions.Configuration.Binder/gen/ConfigurationBindingGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Extensions.Configuration.Binder/gen/Helpers/SourceWriter.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jun 20, 2023
|
@andrewlock I verified that the scenarios in #86348 work following this PR. Please give it another go using our nightly runtime builds - |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #83600.
Generator now intercepts calls to methods on
OptionsBuilderConfigurationExtensionsandOptionsConfigurationServiceCollectionExtensions. This adds to existing support forConfigurationBindermethods.With this change, all the expected/common entry points for configuration binding in ASP.NET + AOT scenarios are now covered. cc @eerhardt @DamianEdwards.
cc @andrewlock issues with #86348 should be fixed following this PR.