[release/7.0-staging] [mono] ILStrip sorts custom attribute table #87933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
needs-area-label
jandupej
added
area-Build-mono
and removed
needs-area-label
lambdageek
approved these changes
Jun 23, 2023
akoeplinger
approved these changes
Jun 26, 2023
|
Approved by tactics via email. |
jandupej
added
Servicing-approved
|
@jandupej you can merge the PR then since we have the new staging branch setup. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #87923 to release/7.0-staging
/cc @steveisok @jandupej
Customer Impact
When an assembly is trimmed with ILStrip, corruption of the custom attribute table can occur. This can cause searching for type attributes to fail, resulting in (rare) runtime crashes. Such an error has been observed by a customer #85414. The PR restores sorting to assembly's custom attribute table as the last step of ILStrip, resolving the said error.
Testing
Open a trimmed assembly in ILSpy and verify that all expected attributes are in place. The customer-reported example lacked all attributes for
System.DateTimeResultinSystem.Private.CoreLib.dll, while it should have reportedIsByRefLikeAttribute,ObsoleteAttributeandCompilerFeatureRequiredAttribute. When fixed ILStrip is used, the expected attributes are present.Risk
Low. There are no new features. The length of the custom attribute table is not changed, its rows are merely sorted by
Parentkey.IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.