Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][non-icu] HybridGlobalization locales covering LocaleStringData. #87972

Closed
wants to merge 6 commits into from
Closed

[browser][non-icu] HybridGlobalization locales covering LocaleStringData. #87972

wants to merge 6 commits into from

Conversation

ilonatommy
Copy link
Member

@ilonatommy ilonatommy commented Jun 23, 2023 •
edited
Loading

Contributes to #79989.

Public APIs afftected by the change:

  • CultureInfo.DisplayName
  • CultureInfo.EnglishName
  • CultureInfo.NativeName
  • NumberFormatInfo.CurrencyDecimalSeparator
  • NumberFormatInfo.CurrencyGroupSeparator
  • NumberFormatInfo.CurrencySymbol
  • NumberFormatInfo.NaNSymbol
  • NumberFormatInfo.NativeDigits
  • NumberFormatInfo.NegativeSign
  • NumberFormatInfo.NumberDecimalSeparator
  • NumberFormatInfo.NumberGroupSeparator
  • NumberFormatInfo.PercentDecimalSeparator
  • NumberFormatInfo.PercentGroupSeparator
  • NumberFormatInfo.PercentSymbol
  • NumberFormatInfo.PerMilleSymbol
  • NumberFormatInfo.PositiveSign

Will fix the issue with #44739 - see update in documentation.

This PR renames all previous hybrid files' suffix: WebAssembly -> Browser.

Not covered and delegated to a follow-up PRs:
NumberFormatInfo properties:
CurrencyDecimalDigits (Int)
CurrencyGroupSizes (Int[])
CurrencyNegativePattern (Int)
CurrencyPositivePattern (Int)
NegativeInfinitySymbol (Calendars)
NumberDecimalDigits (Int)
NumberGroupSizes (Int[])
NumberNegativePattern (Int)
PercentDecimalDigits (Int)
PercentGroupSizes (Int[])
PercentNegativePattern (Int)
PercentPositivePattern (Int)
PositiveInfinitySymbol (Calendars)

TextInfo properties:
IsRightToLeft (Int)

@ilonatommy
Tests for functionalities that fail after removing
adcd6af 
                "-/NumberElements/*/symbols",
                "-/calendar/Gregorian/AmPmMarkers",
                "-/calendar/Gregorian/AmPmMarkersAbbr",
                "-/calendar/Gregorian/AmPmMarkersNarrow",
from locales_tree.
@ilonatommy
Implemented support for LocaleStringData cases.
a10585b
@ilonatommy
Fixing tests.
d40cc05
@ilonatommy ilonatommy self-assigned this Jun 23, 2023
@ghost
Copy link

ghost commented Jun 23, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #79989.

Public APIs:

  • CultureInfo properties
  • CultureInfo.NumberFormat properties

Will fix the issue with #44739.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jun 23, 2023
Closed
pavelsavara
pavelsavara reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@pavelsavara pavelsavara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How many bytes of code we are adding compared to how many we could eliminate ? Could we trim those extra methods when we are not using Hybrid ?

src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems Outdated Show resolved Hide resolved
@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 26, 2023 •
edited
Loading

How many bytes of code we are adding compared to how many we could eliminate ? Could we trim those extra methods when we are not using Hybrid ?

We could trim them. Let's consider the Hybrid scenario: we need this PR that implements ~60% of functionalities + one follow up with the rest of changes. This PR results in +75kB change in System.Private.CoreLib.dll while the planned ICU size reduction it would give us is 74kB. In this case, you are right that the size balance after merging this PR does not look good, no matter if Hybrid is on or off.
I am drafting it in case we would need it to finish implementation of some other Hybrid functionality.

@ilonatommy ilonatommy marked this pull request as draft June 26, 2023 11:36
This was referenced Jun 26, 2023
Closed
Closed
@ilonatommy ilonatommy mentioned this pull request Jul 25, 2023
Merged
@ghost ghost closed this Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pavelsavara pavelsavara pavelsavara left review comments

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

@mkhamoyan mkhamoyan Awaiting requested review from mkhamoyan

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilonatommy @pavelsavara