-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read/Write Big/LittleEndian support for Guid #87993
Read/Write Big/LittleEndian support for Guid #87993
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsClose #86798 issue.
|
MemoryMarshal.Read<Guid>(b); [DoesNotReturn]
@AlexRadch, looks like this was just pending some basic perf numbers. Were you able to collect those? |
I already wrote. I got next scores:
Tests are only for slow paths and only for little-endian processors. New constructor is 10 times faster on my computer. Source code https://github.com/AlexRadch/Temp/tree/Guid_BigLittleEndian_Bench |
Thanks! I didn't see those results anywhere in the comments for this PR when I looked. I must have missed them. |
Close #86798 issue.