Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TcpListener should implement IDisposable #88043

Merged
merged 8 commits into from
Jul 3, 2023
Merged

TcpListener should implement IDisposable #88043

merged 8 commits into from
Jul 3, 2023

Conversation

AlexRadch
Copy link
Contributor

@AlexRadch AlexRadch commented Jun 26, 2023 •
edited by karelz
Loading

Fixes #63114

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 26, 2023
@ghost
Copy link

ghost commented Jun 26, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Close #63114 issue.

Author: AlexRadch
Assignees: -
Labels:

area-System.Net.Sockets, new-api-needs-documentation
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Jun 26, 2023
Closed
@AlexRadch @antonfirsov
Update src/libraries/System.Net.Sockets/src/System/Net/Sockets/TCPLis…
78b84e0 
…tener.cs

Co-authored-by: Anton Firszov <antonfir@gmail.com>
@build-analysis build-analysis bot mentioned this pull request Jun 27, 2023
Closed
antonfirsov
antonfirsov approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This was referenced Jun 27, 2023
Closed
Closed
@antonfirsov antonfirsov merged commit 475c9ac into dotnet:main Jul 3, 2023
98 of 102 checks passed
@karelz karelz added this to the 8.0.0 milestone Jul 3, 2023
@AlexRadch AlexRadch deleted the TcpListener_IDisposable branch July 8, 2023 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Aug 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley left review comments

@stephentoub stephentoub stephentoub approved these changes

@antonfirsov antonfirsov antonfirsov approved these changes

Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Sockets community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

TcpListener should implement IDisposable
5 participants
@AlexRadch @stephentoub @danmoseley @antonfirsov @karelz