Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handwritten binding logic from Logging.Console; use generator instead #88067

Merged
merged 7 commits into from
Jul 14, 2023

Apply suggestions from code review

d673274
Select commit
Loading
Failed to load commit list.
Merged

Remove handwritten binding logic from Logging.Console; use generator instead #88067

Apply suggestions from code review
d673274
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Jul 14, 2023 in 0s

.NET Result Analysis

Details

Known Repository Errors

Build Failures

runtime /

[:construction: Report infrastructure issue] [:page_facing_up: Report repository issue]
    ❌We stopped hearing from agent NetCore-Public 393. Verify the agent machine is running and has a healthy network connection. Anything that terminates an agent process, starves it for CPU, or blocks its network access can cause this error. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

Known test errors

Test Failures (19 tests failed)

[All failing tests from runtime]

⚠️ 16 test failures are not displayed due to space limitations.

❌ ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage [Console] [Details] [Artifacts] [89.71% failure rate]
[:construction: Report test infrastructure issue] [:page_facing_up: Report test repository issue]

Failing Configurations (19)

  • Ubuntu.1804.Arm64.Open
  • Debian.11.Arm64.Open
  • Alpine.315.Amd64.Open
  • Debian.11.Amd64.Open
  • Centos.8.Amd64.Open
  • Debian.11.Amd64.Open
  • net8.0-linux-Debug-x64-Mono_release-Ubuntu.1804.Amd64.Open
  • net8.0-windows-Release-x86-CoreCLR_release-Windows.Amd64.Server2022.Open
  • net8.0-windows-Release-x86-CoreCLR_release-Windows.7.Amd64.Open
  • Centos.8.Amd64.Open
  • Debian.11.Amd64.Open
  • net8.0-linux-Debug-x64-CoreCLR_release-Ubuntu.1804.Amd64.Open
  • net8.0-osx-Debug-x64-Mono_release-OSX.1200.Amd64.Open
  • net8.0-osx-Debug-x64-CoreCLR_release-OSX.1200.Amd64.Open
  • net8.0-windows-Debug-x64-CoreCLR_release-Windows.81.Amd64.Open
  • net8.0-windows-Debug-x64-CoreCLR_release-Windows.Amd64.Server2022.Open
  • net8.0-windows-Debug-x64-CoreCLR_release-Windows.11.Amd64.Client.Open
  • Windows.Nano.1809.Amd64.Open
  • net8.0-osx-Debug-x64-CoreCLR_checked-OSX.1200.Amd64.Open
Data Driven SubResults
    ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(id: \"CompileFails.cs:560\", source: \"using System.Runtime.InteropServices;\\nusing Syste\"..., diagnostics: [?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior., ?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.])
    Exception Message
    Microsoft.CodeAnalysis.Testing.Verifiers.EqualWithMessageException : Mismatch between number of diagnostics returned, expected "2" actual "1"
    

    Diagnostics:
    // /0/Test0.cs(8,35): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.
    new DiagnosticResult("SYSLIB1063", DiagnosticSeverity.Info).WithSpan(8, 35, 8, 36).WithSpan(8, 18, 8, 29).WithArguments("[In] and [Out] attributes", "p", "The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior."),

    Assert.Equal() Failure
    Expected: 2
    Actual: 1


    Stack Trace

       at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[Int32](Int32 expected, Int32 actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 52
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].VerifyDiagnosticResults(IEnumerable`1 actualResults, ImmutableArray`1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 562
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<VerifyDiagnosticsAsync>d__69[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 465
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunImplAsync>d__64[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 219
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunAsync>d__63[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 188
    at ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(String id, String source, DiagnosticResult[] diagnostics) in /_/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs:line 854
    --- End of stack trace from previous location ---

    ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(id: \"CompileFails.cs:564\", source: \"using System.Runtime.InteropServices;\\nusing Syste\"..., diagnostics: [?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior., ?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.])
    Exception Message

    Microsoft.CodeAnalysis.Testing.Verifiers.EqualWithMessageException : Mismatch between number of diagnostics returned, expected "2" actual "1"

    Diagnostics:
    // /0/Test0.cs(8,36): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.
    new DiagnosticResult("SYSLIB1063", DiagnosticSeverity.Info).WithSpan(8, 36, 8, 37).WithSpan(8, 18, 8, 29).WithArguments("[In] and [Out] attributes", "p", "The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior."),

    Assert.Equal() Failure
    Expected: 2
    Actual: 1


    Stack Trace

       at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[Int32](Int32 expected, Int32 actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 52
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].VerifyDiagnosticResults(IEnumerable`1 actualResults, ImmutableArray`1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 562
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<VerifyDiagnosticsAsync>d__69[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 465
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunImplAsync>d__64[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 219
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunAsync>d__63[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 188
    at ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(String id, String source, DiagnosticResult[] diagnostics) in /_/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs:line 854
    --- End of stack trace from previous location ---

    ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(id: \"CompileFails.cs:568\", source: \"using System.Runtime.InteropServices;\\nusing Syste\"..., diagnostics: [?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior., ?(1,1,1,1): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.])
    Exception Message

    Microsoft.CodeAnalysis.Testing.Verifiers.EqualWithMessageException : Mismatch between number of diagnostics returned, expected "2" actual "1"

    Diagnostics:
    // /0/Test0.cs(8,65): info SYSLIB1063: Unnecessary marshalling info '[In] and [Out] attributes' was provided for parameter 'p'. The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior.
    new DiagnosticResult("SYSLIB1063", DiagnosticSeverity.Info).WithSpan(8, 65, 8, 66).WithSpan(8, 18, 8, 29).WithArguments("[In] and [Out] attributes", "p", "The '[In]' attribute is not necessary unless the '[Out]' attribute is also used. The behavior of the '[In]' attribute without the '[Out]' attribute is the same as the default behavior."),

    Assert.Equal() Failure
    Expected: 2
    Actual: 1


    Stack Trace

       at Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier.Equal[Int32](Int32 expected, Int32 actual, String message) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Testing.Verifiers.XUnit/XUnitVerifier.cs:line 52
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].VerifyDiagnosticResults(IEnumerable`1 actualResults, ImmutableArray`1 analyzers, DiagnosticResult[] expectedResults, IVerifier verifier) in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 562
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<VerifyDiagnosticsAsync>d__69[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 465
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunImplAsync>d__64[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 219
    at Microsoft.CodeAnalysis.Testing.AnalyzerTest`1.<RunAsync>d__63[[Microsoft.CodeAnalysis.Testing.Verifiers.XUnitVerifier, Microsoft.CodeAnalysis.Testing.Verifiers.XUnit, Version=1.1.2.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35]].MoveNext() in /_/src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Analyzer.Testing/AnalyzerTest`1.cs:line 188
    at ComInterfaceGenerator.Unit.Tests.CompileFails.VerifyByValueMarshallingAttributeUsage(String id, String source, DiagnosticResult[] diagnostics) in /_/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs:line 854
    --- End of stack trace from previous location ---

16 other tests are failing: [All failing tests from runtime]

Was this helpful? Yes No