Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OptionsValidator source-gen to skip static and const members #88254
Fix OptionsValidator source-gen to skip static and const members #88254
Changes from 2 commits
20731a7
c1493e6
b36f611
5dc0667
cd932c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux arm Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl arm Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl arm64 Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux arm64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build freebsd x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build osx x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build osx arm64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 97 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L97
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux arm Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl arm Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl arm64 Release)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux arm64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build linux_musl x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build freebsd x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build browser-wasm linux Release LibraryTests_EAT)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build osx x64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime (Build Libraries Build osx arm64 Debug)
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
Check failure on line 98 in src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs
Azure Pipelines / runtime
src/libraries/Microsoft.Extensions.Options/gen/DiagDescriptors.cs#L98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the correct thing to generate error and not just ignoring the statics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change this to warning, or completely ignore these cases. But it's better to notify a user about incorrect usage and that these members won't be validated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good if we check what is the runtime behavior when having the validation attribute on the statics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that, I would say making it as
warning
will make sense.@jeffhandley @geeknoid what do you think about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out it was a warning already (bad copy-paste). Added an additional assertion in tests to ensure that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't check
string
internals anymore