Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around for Android builds using GCC for cross compiler native tools build #88345

Merged
merged 11 commits into from
Jul 10, 2023

Conversation

directhex
Copy link
Contributor

@directhex directhex commented Jul 3, 2023

Closes: #88344

@directhex directhex requested a review from jkotas July 3, 2023 17:26
@ghost ghost assigned directhex Jul 3, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 3, 2023
@directhex
Copy link
Contributor Author

Sigh. OK, so disabling the cross compiler is enough for the basic tests, but not the allsubsets tests (which have a hard dependency on a cross-compiler).

@directhex
Copy link
Contributor Author

@directhex
Copy link
Contributor Author

Reopening to test some more fixes. This will definitely NOT fix the Android AllSubsets builds, but might fix others

@directhex
Copy link
Contributor Author

I'm confused why all these iOS/tvOS failures aren't expected. src/tests/tracing/eventpipe/processinfo3/processinfo3.cs specifies

            string expectedPortableRidOs = null;
            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
            {
                expectedPortableRidOs = "win";
            }
            else if (RuntimeInformation.IsOSPlatform(OSPlatform.OSX))
            {
                expectedPortableRidOs = "osx";
            }
            else if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux))
            {
                expectedPortableRidOs = "linux";
            }

            Utils.Assert(!string.IsNullOrEmpty(expectedPortableRidOs), $"Unable to calculate expected portable RID OS.");

Why would that ever pass on a platform that isn't OSX, Linux or Win? Hence [20:44:10] dbug: System.Exception: Unable to calculate expected portable RID OS.

@jkotas
Copy link
Member

jkotas commented Jul 4, 2023

Why would that ever pass on a platform that isn't OSX, Linux or Win?

#88186

@directhex
Copy link
Contributor Author

directhex commented Jul 4, 2023 via email

@danmoseley danmoseley added area-Infrastructure-mono and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 4, 2023
@ghost
Copy link

ghost commented Jul 4, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes: #88344

Author: directhex
Assignees: directhex
Labels:

area-Infrastructure-mono

Milestone: -

@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@directhex
Copy link
Contributor Author

/azp run runtime-wasm

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

1 similar comment
@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

@dotnet dotnet deleted a comment from azure-pipelines bot Jul 10, 2023
@dotnet dotnet deleted a comment from azure-pipelines bot Jul 10, 2023
@steveisok
Copy link
Member

/azp run runtime-wasm

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

@directhex
Copy link
Contributor Author

/azp run runtime-wasm

@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

@directhex
Copy link
Contributor Author

OK, one /azp run worked and one didn't? This is not a productive way to do my job.

@directhex
Copy link
Contributor Author

/azp run runtime-android

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88345 in repo dotnet/runtime

@directhex
Copy link
Contributor Author

/azp run runtime-androidemulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

Well we're gonna have to trust the androidemulator run, because none of the others feel like joining the party

@directhex
Copy link
Contributor Author

This seems mergeable. We've gone from "Android jobs don't build" to "Android jobs build but there are some test failures" which feels like a big upgrade

@directhex directhex merged commit b6e8073 into dotnet:main Jul 10, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build break in Mono Android extra-platforms
5 participants