-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Disable runtime test dependent on creating a process #88498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tracing/eventpipe/simpleruntimeeventvalidation`: ``` Generated app bundle at /root/helix/work/workitem/e/tracing/eventpipe/simpleruntimeeventvalidation/simpleruntimeeventvalidation/WasmApp/ Incoming arguments: --run simpleruntimeeventvalidation.dll Application arguments: --run simpleruntimeeventvalidation.dll console.info: Initializing dotnet version 8.0.0-ci commit hash f47b553f129cfa7f006cb1a2f2088112c5ca0112 0.0s: ==TEST STARTING== 0.1s: System.PlatformNotSupportedException: System.Diagnostics.Process is not supported on this platform. at System.Diagnostics.Process.GetCurrentProcess() at Tracing.Tests.Common.IpcTraceTest.Validate(Boolean enableRundownProvider) at Tracing.Tests.Common.IpcTraceTest.RunAndValidateEventCounts(Dictionary`2 expectedEventCounts, Action eventGeneratingAction, List`1 providers, Int32 circularBufferMB, Func`2 optionalTraceValidator, Boolean enableRundownProvider) 0.1s: ==TEST FINISHED: FAILED!== test-main.js exiting simpleruntimeeventvalidation.dll with result -1 console.info: WASM EXIT -1 ``` This was added in dotnet#87785, but got merged on red.
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Jul 6, 2023
ghost
assigned radical
Jul 6, 2023
Tagging subscribers to 'arch-wasm': @lewing Issue Details
This was added in #87785, but got
|
cc @LakshanF |
radical
added
area-VM-meta-mono
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Jul 6, 2023
hoyosjs
approved these changes
Jul 7, 2023
The remaining failures are for the same test on non-wasm mono, and will be disabled in #88500 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88499
tracing/eventpipe/simpleruntimeeventvalidation
:This was added in #87785, but got merged on red.