Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have jitstress_isas_x86_evex set PreferredVectorBitWidth=512 #88531

Merged
merged 6 commits into from
Jul 8, 2023

Conversation

tannergooding
Copy link
Member

@tannergooding tannergooding commented Jul 7, 2023

This resolves #88233 by ensuring the evex stress job runs with DOTNET_PreferredVectorBitWidth=512.

Given we're already stress testing EVEX, ensuring that Vector512.IsHardwareAccelerated reports true in that case matches the general theme of the job.

This also fixes an issue with IsHardwareAccelerated not respecting the right flags/properties and updates the tests to check for the right values, accordingly.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 7, 2023
@ghost ghost assigned tannergooding Jul 7, 2023
@ghost
Copy link

ghost commented Jul 7, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

This resolves #88233 by ensuring the evex stress job runs with DOTNET_PreferredVectorBitWidth=512.

Given we're already stress testing EVEX, ensuring that Vector512.IsHardwareAccelerated reports true in that case matches the general theme of the job.

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@tannergooding tannergooding added the avx512 Related to the AVX-512 architecture label Jul 7, 2023
@tannergooding tannergooding marked this pull request as ready for review July 7, 2023 19:24
@tannergooding
Copy link
Member Author

tannergooding commented Jul 7, 2023

CC. @dotnet/jit-contrib, as per the top post this resolves the issue where we weren't running CI jobs where Vector512.IsHardwareAccelerated was true and ensures that IsHardwareAccelerated returns true when it was expected to do so.

@BruceForstall
Copy link
Member

Do you want to trigger runtime-coreclr jitstress-isas-avx512?

@tannergooding
Copy link
Member Author

/azp run runtime-coreclr jitstress-isas-avx512

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@tannergooding tannergooding merged commit 42742cd into dotnet:main Jul 8, 2023
@tannergooding tannergooding deleted the vector512-ci branch July 8, 2023 17:39
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CI test coverage for Vector512
2 participants