Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Disable default JSON reflection when PublishTrimmed == true" #88612

Closed
wants to merge 1 commit into from
Closed

Revert "Disable default JSON reflection when PublishTrimmed == true" #88612

wants to merge 1 commit into from

Conversation

lewing
Copy link
Member

@lewing lewing commented Jul 10, 2023

Reverts #88480 until the lanes it broke can be fixed

@lewing lewing requested a review from sbomer as a code owner July 10, 2023 17:25
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 10, 2023
@ghost ghost assigned lewing Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #88480 until the lanes it broke can be fixed

Author: lewing
Assignees: -
Labels:

linkable-framework
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jul 10, 2023
@ghost
Copy link

ghost commented Jul 10, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #88480 until the lanes it broke can be fixed

Author: lewing
Assignees: lewing
Labels:

linkable-framework, area-Tools-ILLink
Milestone: -

@lewing lewing requested review from eiriktsarpalis and radical July 10, 2023 17:25
This was referenced Jul 10, 2023
Closed
Merged
@eiriktsarpalis
Copy link
Member

cc @eerhardt

@lewing
Copy link
Member Author

lewing commented Jul 10, 2023 •
edited
Loading

I may have misread the failures across the prs. We can hold off on this for the moment

@eiriktsarpalis
Copy link
Member

Context: #88480 (comment). Are there any test failures that #88480 specifically introduced?

@lewing
Copy link
Member Author

lewing commented Jul 10, 2023

Context: #88480 (comment). Are there any test failures that #88480 specifically introduced?

I think we may be hitting issues around which ilink is being used for which tests #88245 (comment)

@lewing
Copy link
Member Author

lewing commented Jul 10, 2023 •
edited
Loading

It appears that #88245 has the runtime versions the illink task/tools flowing back into runtime and breaking things there, whereas dotnet/performance is using the upstream sdk versions and also having problems.

@build-analysis build-analysis bot mentioned this pull request Jul 10, 2023
Closed
@lewing
Copy link
Member Author

lewing commented Jul 10, 2023

closing this now that we have a plan

@lewing lewing closed this Jul 10, 2023
@lewing lewing deleted the revert-88480-publishtrimmed-disablereflection branch July 10, 2023 21:17
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@sbomer sbomer Awaiting requested review from sbomer sbomer is a code owner

@eiriktsarpalis eiriktsarpalis Awaiting requested review from eiriktsarpalis

Assignees

@lewing lewing

Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @eiriktsarpalis @radical