-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make firing of ETW events in nativeaot opt-in via the enabled/disabled lib #88800
Conversation
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue Details
The actual implementation still:
This will enable us to actually reconcile the ETW and EventPipe tracking/contexts/callbacks in nativeaot, which we will need to address #88162 and to switch to the generation scripts based on the event manifest instead of checking in modified parts of the output and manually updating.
|
abfefdc
to
02e28c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! The clean separation is going to make it much easier, both to add new events and for the change to auto-generated python scripts.
Failure is #88870. |
FireEtw*
instead ofEventPipeWriteEvent*
The actual implementation still:
This will enable us to actually reconcile the ETW and EventPipe tracking/contexts/callbacks in nativeaot, which we will need to address #88162 and to switch to the generation scripts based on the event manifest instead of checking in modified parts of the output and manually updating.
I'd also like to move some of the files that are no longer part of the core runtime into a subdirectory (of nativeaot/Runtime) - but in a separate change.