Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that INumberBase implements IUtf8SpanFormattable #88840

Merged
merged 5 commits into from
Jul 14, 2023
Merged

Ensure that INumberBase implements IUtf8SpanFormattable #88840

merged 5 commits into from
Jul 14, 2023

Commits on Jul 13, 2023

  1. Ensure that INumberBase implements IUtf8SpanFormattable

    @tannergooding
    tannergooding committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fe94d1b View commit details
    Browse the repository at this point in the history

  2. Ensure we return the rented buffers in the IUtf8SpanFormattable.TryFo… 

    …rmat DIM
    @tannergooding
    tannergooding committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    183c7b2 View commit details
    Browse the repository at this point in the history

  3. Remember to slice the utf16Destination buffer and ensure we throw if … 

    …we couldn't transcode back to valid UTF-8 in the DIM
    @tannergooding
    tannergooding committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    fc54f30 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. Update src/libraries/System.Private.CoreLib/src/System/Numerics/INumb… 

    …erBase.cs

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
    @tannergooding @MihaZupan
    tannergooding and MihaZupan committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0c8d6b3 View commit details
    Browse the repository at this point in the history

  2. Update src/libraries/System.Private.CoreLib/src/Resources/Strings.resx 

    Co-authored-by: Dan Moseley <danmose@microsoft.com>
    @tannergooding @danmoseley
    tannergooding and danmoseley committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    9ab1604 View commit details
    Browse the repository at this point in the history