-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable StressLogAnalyzer to read stress logs from old coreclr running with a new clrgc. #88852
Merged
jkoritzinsky
merged 1 commit into
dotnet:main
from
jkoritzinsky:stressloganalyzer-downlevel
Jul 14, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| #include <stdint.h> | ||
|
|
||
| extern StressLog::StressLogHeader* s_hdr; | ||
|
|
||
| // A version-aware reader for memory-mapped stress log messages. | ||
| struct StressMsgReader | ||
| { | ||
| private: | ||
| struct StressMsgSmallOffset | ||
| { | ||
| uint32_t numberOfArgsLow : 3; // at most 7 arguments here | ||
| uint32_t formatOffset : 26; // low bits offset of format string in modules | ||
| uint32_t numberOfArgsHigh : 3; // extend number of args in a backward compat way | ||
| uint32_t facility; // facility used to log the entry | ||
| uint64_t timeStamp; // time when mssg was logged | ||
| void* args[0]; // variable number of arguments | ||
| }; | ||
|
|
||
| void* m_rawMsg; | ||
| public: | ||
| StressMsgReader() = default; | ||
|
|
||
| StressMsgReader(void* msg) | ||
| :m_rawMsg(msg) | ||
| { | ||
| } | ||
|
|
||
| uint64_t GetFormatOffset() const | ||
| { | ||
| if (s_hdr->version == 0x00010001) | ||
| { | ||
| return ((StressMsgSmallOffset*)m_rawMsg)->formatOffset; | ||
| } | ||
| return ((StressMsg*)m_rawMsg)->GetFormatOffset(); | ||
| } | ||
|
|
||
| uint32_t GetNumberOfArgs() const | ||
| { | ||
| if (s_hdr->version == 0x00010001) | ||
| { | ||
| return ((StressMsgSmallOffset*)m_rawMsg)->numberOfArgsHigh << 3 | ((StressMsgSmallOffset*)m_rawMsg)->numberOfArgsLow; | ||
| } | ||
| return ((StressMsg*)m_rawMsg)->GetNumberOfArgs(); | ||
| } | ||
|
|
||
| uint32_t GetFacility() const | ||
| { | ||
| if (s_hdr->version == 0x00010001) | ||
| { | ||
| return ((StressMsgSmallOffset*)m_rawMsg)->facility; | ||
| } | ||
| return ((StressMsg*)m_rawMsg)->GetFacility(); | ||
| } | ||
|
|
||
| uint64_t GetTimeStamp() const | ||
| { | ||
| if (s_hdr->version == 0x00010001) | ||
| { | ||
| return ((StressMsgSmallOffset*)m_rawMsg)->timeStamp; | ||
| } | ||
| return ((StressMsg*)m_rawMsg)->GetTimeStamp(); | ||
| } | ||
|
|
||
| void** GetArgs() const | ||
| { | ||
| if (s_hdr->version == 0x00010001) | ||
| { | ||
| return ((StressMsgSmallOffset*)m_rawMsg)->args; | ||
| } | ||
| return ((StressMsg*)m_rawMsg)->args; | ||
| } | ||
|
|
||
| bool operator==(std::nullptr_t) const | ||
| { | ||
| return m_rawMsg == nullptr; | ||
| } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - thank you!