Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip internal tool restore on mac #88877

Merged
merged 3 commits into from
Jul 14, 2023
Merged

Skip internal tool restore on mac #88877

merged 3 commits into from
Jul 14, 2023

Conversation

agocke
Copy link
Member

@agocke agocke commented Jul 14, 2023

Looks like the Mac internal builds don't consume anything from the internal tools. This looks to be the highest rate rate for build timing out

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 14, 2023
@ghost ghost assigned agocke Jul 14, 2023
@hoyosjs
Copy link
Member

hoyosjs commented Jul 14, 2023

Have you tested this one in internal? This one is usually needed to sign, to do swix, and to do IBC stuff which we don't do in-repo. We do sign on macOS, but I think that uses the task and not the restored microbuild dlls.

@agocke
Copy link
Member Author

agocke commented Jul 14, 2023

Yup, I ran an official build and signing seemed to proceed just fine. Can't rule out a mistake entirely, but it looked OK to me.

@agocke agocke merged commit 73638d6 into dotnet:main Jul 14, 2023
@agocke agocke deleted the debug-official branch July 14, 2023 07:06
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants