Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing using statement #88906

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Fix missing using statement #88906

merged 1 commit into from
Jul 14, 2023

Conversation

vitek-karas
Copy link
Member

Add a using which was incorrectly removed because it's only necessary in NativeAOT configuration

@mrvoorhe fyi

Fixes #88870

Add a using which was incorrectly removed because it's only necessary in NativeAOT configuration
@vitek-karas vitek-karas added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Jul 14, 2023
@vitek-karas vitek-karas added this to the 8.0.0 milestone Jul 14, 2023
@vitek-karas vitek-karas requested a review from sbomer July 14, 2023 11:31
@vitek-karas vitek-karas requested a review from marek-safar as a code owner July 14, 2023 11:31
@vitek-karas vitek-karas self-assigned this Jul 14, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Jul 14, 2023
@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to this area: @agocke, @sbomer, @vitek-karas
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a using which was incorrectly removed because it's only necessary in NativeAOT configuration

@mrvoorhe fyi

Fixes #88870

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Tools-ILLink

Milestone: 8.0.0

@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Add a using which was incorrectly removed because it's only necessary in NativeAOT configuration

@mrvoorhe fyi

Fixes #88870

Author: vitek-karas
Assignees: vitek-karas
Labels:

linkable-framework, area-Tools-ILLink

Milestone: 8.0.0

@vitek-karas
Copy link
Member Author

Failures are unrelated.

@vitek-karas vitek-karas merged commit 0ba2597 into dotnet:main Jul 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Tools-ILLink .NET linker development as well as trimming analyzers linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono.Linker.Tests.TestCases.All.DynamicDependencies test failure
2 participants