Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTFn->UTF-n #88913

Merged
merged 3 commits into from
Jul 14, 2023
Merged

UTFn->UTF-n #88913

merged 3 commits into from
Jul 14, 2023

Conversation

danmoseley
Copy link
Member

It's my understanding from https://www.unicode.org/reports/tr17 that the hyphen form is correct. So make strings and doc comments consistent.

@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

It's my understanding from https://www.unicode.org/reports/tr17 that the hyphen form is correct. So make strings and doc comments consistent.

Author: danmoseley
Assignees: danmoseley
Labels:

area-Meta

Milestone: -

@tannergooding
Copy link
Member

Looks like this just catches the all upper-case UTF8 to UTF-8. We still have a number of places that use other cases (such as utf8 or Utf8, same with 16) which presumably should also be fixed?
-- Notably lot more false positives due to locals with these names

@danmoseley
Copy link
Member Author

danmoseley commented Jul 14, 2023

Looks like this just catches the all upper-case UTF8 to UTF-8. We still have a number of places that use other cases (such as utf8 or Utf8, same with 16) which presumably should also be fixed?

I only looked in comments (doc comments only) and strings. Are there any there? Didn't see any. I could churn all the code but it didn't seem worth it as customers don't see it.

@danmoseley
Copy link
Member Author

test failures are surely unrelated -- ios/tvos device not connecting, etc. seems to be a number of active failures in the repo right now.

@stephentoub
Copy link
Member

These XML comments improvements won't automatically flow to the official docs. Do they need updating as well, or do they already do it the desired way?

@ghost ghost locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants