Fix duplicated assets in official build #89188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The additional osx-x64 and osx-arm64 legs added for NativeAOT in dotnet#89018 caused the `runtime.osx-*.Microsoft.DotNet.ILCompiler` and runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated. This change makes sure we only publish them from one leg (the CoreCLR one).
dotnet-issue-labeler
bot
added
the
needs-area-label
akoeplinger
added
area-Infrastructure-libraries
and removed
needs-area-label
|
/backport to release/8.0-preview7 |
|
Started backporting to release/8.0-preview7: https://github.com/dotnet/runtime/actions/runs/5601208211 |
ViktorHofer
reviewed
Jul 19, 2023
| @@ -1,9 +1,9 @@ | |||
| <Project> | |||
| <Import Sdk="Microsoft.Build.Traversal" Project="Sdk.props" /> | |||
|
|
|||
| <ItemGroup> | |||
| <ItemGroup Condition="'$(BuildNativeAOTRuntimePack)' != 'true'"> | |||
There was a problem hiding this comment.
I'm not exactly sure what the intention of that property was initially. Suppress both the meta package and the RID specific package? If yes, then the change looks good.
There was a problem hiding this comment.
Yes, we don't need these packages when building the runtime packs.
ViktorHofer
approved these changes
Jul 19, 2023
This was referenced Jul 19, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The additional osx-x64 and osx-arm64 legs added for NativeAOT in #89018 caused the
runtime.osx-*.Microsoft.DotNet.ILCompilerand runtime.osx-*.runtime.native.System.IO.Ports` packages to be duplicated.This change makes sure we only publish them from one leg (the CoreCLR one).