Code

Crossplatform ResourceUpdater#89303

Code

Merged

elinor-fung merged 79 commits intodotnet:maindotnet/runtime:mainfrom anatawa12:crossplatform-resource-updateranatawa12/dotnet-runtime:crossplatform-resource-updaterCopy head branch name to clipboardAug 8, 2023

+912-413

Commits

Commits on Jul 18, 2023

• add Mono.Cecil.Binary from mono repository

  anatawa12

  committed
  ad7e0e2

  Copy full SHA for ad7e0e2

• port Mono.Cecil.Binary onto netstandard2.0

  anatawa12

  committed
  36e12c8

  Copy full SHA for 36e12c8

• reformat Mono.Cecil.Binary

  anatawa12

  committed
  379d8a8

  Copy full SHA for 379d8a8

• make Mono.Cecil.Binary.Image and Mono.Cecil.Binary.ImageReader public

  anatawa12

  committed
  a6d09c6

  Copy full SHA for a6d09c6

Commits on Jul 19, 2023

• rewrite ResourceUpdater.AddResource with Mono.Cecil.Binary

  anatawa12

  committed
  a53eb03

  Copy full SHA for a53eb03

• reimplement AddResourcesFromPEImage with Mono.Cecil.Binary

  anatawa12

  committed
  cf8effd

  Copy full SHA for cf8effd

• reimplement ResourceUpdater with Mono.Cecil.Binary.ImageWriter

  anatawa12

  committed
  11e2c45

  Copy full SHA for 11e2c45

• fix: remove unused csproj

  anatawa12

  committed
  2d5d598

  Copy full SHA for 2d5d598

• publish mono cecil binary

  anatawa12

  committed
  a06aeef

  Copy full SHA for a06aeef

Commits on Jul 20, 2023

• chore: remove unnecessary mappings

  anatawa12

  committed
  7778151

  Copy full SHA for 7778151

• leave open FileStream

  anatawa12

  committed
  bff5f19

  Copy full SHA for bff5f19

Commits on Jul 21, 2023

• update binary with our own code instead of ImageWriter

  Show description for 027cf55
  anatawa12

  committed
  027cf55

  Copy full SHA for 027cf55

• remove unused files from Mono.Cecil.Binary

  anatawa12

  committed
  2ccadd8

  Copy full SHA for 2ccadd8

• flatten Mono.Cecil.Binary

  anatawa12

  committed
  6022cfd

  Copy full SHA for 6022cfd

Commits on Jul 25, 2023

• fix

  anatawa12

  committed
  455eab7

  Copy full SHA for 455eab7

• clear padding

  anatawa12

  committed
  dde91d4

  Copy full SHA for dde91d4

• fix ResourceWriter

  anatawa12

  committed
  a4de95c

  Copy full SHA for a4de95c

Commits on Jul 26, 2023

• reimplement ResourceUpdater with System.Reflection.Metadata and ILCompiler.Win32Resources

  anatawa12

  committed
  df8b502

  Copy full SHA for df8b502

• make ResourceData.WriteResources working

  anatawa12

  committed
  832629f

  Copy full SHA for 832629f

• remove Mono.Cecil.Binary

  anatawa12

  committed
  4a7c516

  Copy full SHA for 4a7c516

• add unit test for ResourceUpdater

  anatawa12

  committed
  99d0f3d

  Copy full SHA for 99d0f3d

• fix bad image file if resource delta is small

  anatawa12

  committed
  8dd9c0a

  Copy full SHA for 8dd9c0a

• ResourceUpdaterAddResource is WindowsOnlyFact

  anatawa12

  committed
  9542736

  Copy full SHA for 9542736

Commits on Jul 27, 2023

• Use CoreClrProjectRoot instead of long relative path

  Show description for 55631c2
  

  anatawa12

  and

  am11

  authored
  55631c2

  Copy full SHA for 55631c2

• make ResourceUpdaterAddResource test simple

  anatawa12

  committed
  8059a5c

  Copy full SHA for 8059a5c

• use int instead of uint

  anatawa12

  committed
  49e1130

  Copy full SHA for 49e1130

• fix ResourceUpdaterAddResource test

  anatawa12

  committed
  033ad24

  Copy full SHA for 033ad24

• support adding section in ResourceUpdater

  anatawa12

  committed
  08b4cd1

  Copy full SHA for 08b4cd1

• add more unit tests

  anatawa12

  committed
  5e6f581

  Copy full SHA for 5e6f581

• use GetExecutingAssembly for PE with .rsrc section

  anatawa12

  committed
  e5fc1e6

  Copy full SHA for e5fc1e6

Commits on Jul 28, 2023

• Merge branch 'main' into crossplatform-resource-updater

  anatawa12

  committed
  5abe05d

  Copy full SHA for 5abe05d

• fix: ResourceUpdater is not disposed in HostWriter

  anatawa12

  committed
  efe5b1c

  Copy full SHA for efe5b1c

• extract ObjectDataBuilder for HostModel to an separated file

  anatawa12

  committed
  3a60147

  Copy full SHA for 3a60147

Commits on Aug 2, 2023

• move Win32Resources for host model to Microsoft.NET.HostModel.Win32Resources

  anatawa12

  committed
  5c2bf12

  Copy full SHA for 5c2bf12

• move files for Win32Resources

  anatawa12

  committed
  e630a0e

  Copy full SHA for e630a0e

• improve readability with #if

  anatawa12

  committed
  6bf8b25

  Copy full SHA for 6bf8b25

• move ResourceUpdaterTests to Microsoft.NET.HostModel.AppHost.Tests

  anatawa12

  committed
  42c5798

  Copy full SHA for 42c5798

• fix duplicated code in ResourceUpdaterTests

  anatawa12

  committed
  20b384e

  Copy full SHA for 20b384e

• fix pe32InitializedDataSizeOffset

  anatawa12

  committed
  4ae6177

  Copy full SHA for 4ae6177

• rename offsets

  anatawa12

  committed
  1a64d91

  Copy full SHA for 1a64d91

• move offsets constants to into Offsets class

  anatawa12

  committed
  5878ecb

  Copy full SHA for 5878ecb

• throw InvalidOperationException if Update is already called.

  anatawa12

  committed
  b893113

  Copy full SHA for b893113

• use RetryUtil.RetryOnIOError

  anatawa12

  committed
  dce2f4c

  Copy full SHA for dce2f4c

• addd more tests for AddResource

  anatawa12

  committed
  3703177

  Copy full SHA for 3703177

• add test for AddResourcesFromPEImage

  anatawa12

  committed
  5241c08

  Copy full SHA for 5241c08

• use GetAllResources in CopyResourcesFrom

  anatawa12

  committed
  75340cf

  Copy full SHA for 75340cf

• set fileshare

  anatawa12

  committed
  0788ea5

  Copy full SHA for 0788ea5

• use memory mapped file in ResourceUpdater

  anatawa12

  committed
  1e6f4d8

  Copy full SHA for 1e6f4d8

• remove outdated comment

  anatawa12

  committed
  0a27042

  Copy full SHA for 0a27042

Commits on Aug 4, 2023

• DosStab -> DosStub

  anatawa12

  committed
  81a05fb

  Copy full SHA for 81a05fb

• fix styling

  anatawa12

  committed
  7aabeef

  Copy full SHA for 7aabeef

• use using block instead of using var

  anatawa12

  committed
  bd3bab8

  Copy full SHA for bd3bab8

• buffer -> accessor

  anatawa12

  committed
  36c8579

  Copy full SHA for 36c8579

• CopyRes(Name|Type) -> SelectRes(Name|Type)

  anatawa12

  committed
  ac45717

  Copy full SHA for ac45717

• use Assert.Fail instead of InvalidOperationException

  anatawa12

  committed
  d6d390a

  Copy full SHA for d6d390a

• use CreateTestPEFileWithoutRsrc in AddResourcesFromPEImage

  anatawa12

  committed
  30b3943

  Copy full SHA for 30b3943

• PE(32|64)(InitializedDataSize|SizeOfImage) -> (InitializedDataSize|SizeOfImage)

  anatawa12

  committed
  a9e975c

  Copy full SHA for a9e975c

• add dataDirectoriesOffset and pull the updating of data directories out of the if

  anatawa12

  committed
  eef78a2

  Copy full SHA for eef78a2

• add offsets around DataDirectory

  anatawa12

  committed
  34ca149

  Copy full SHA for 34ca149

• throw exception in ThrowExceptionForInvalidUpdate

  anatawa12

  committed
  9288922

  Copy full SHA for 9288922

• fix parameter names of AddResource

  anatawa12

  committed
  33abdc8

  Copy full SHA for 33abdc8

• reorder parameters of AddResource and AddResourceInternal to match with FindResource

  anatawa12

  committed
  647b250

  Copy full SHA for 647b250

• add test ResourceUpdaterAddResourceTwoSameUShortTypeWithDifferName

  anatawa12

  committed
  a224eda

  Copy full SHA for a224eda

• move calling ResourceUpdater and open appHostDestinationFilePath once

  anatawa12

  committed
  d174ece

  Copy full SHA for d174ece

• use single code to modify InitializedDataSize and SizeOfImage

  anatawa12

  committed
  545965b

  Copy full SHA for 545965b

• seek to head in ResourceUpdater constructor

  anatawa12

  committed
  5a1cfd0

  Copy full SHA for 5a1cfd0

Commits on Aug 5, 2023

• insert blank line

  Show description for 8a8ca68
  

  anatawa12

  and

  elinor-fung

  authored
  8a8ca68

  Copy full SHA for 8a8ca68

• Update comment

  Show description for b2bbd1b
  

  anatawa12

  and

  elinor-fung

  authored
  b2bbd1b

  Copy full SHA for b2bbd1b

• improve test name

  anatawa12

  committed
  92defd3

  Copy full SHA for 92defd3

• remove throw from ThrowExceptionForInvalidUpdate caller

  anatawa12

  committed
  ab5d5e0

  Copy full SHA for ab5d5e0

• strip ResourceData constructor with PEReader from ilc/crossgen

  anatawa12

  committed
  30c3451

  Copy full SHA for 30c3451

• update doc comments in ResourceUpdater

  anatawa12

  committed
  de8455f

  Copy full SHA for de8455f

• add test for app with unknown language resource

  anatawa12

  committed
  7ec110e

  Copy full SHA for 7ec110e

• fix CreateAppHost failure from old SDK

  anatawa12

  committed
  ed3f32a

  Copy full SHA for ed3f32a

Commits on Aug 6, 2023

• share offsets constants of PE between PEUtils and ResourceUpdater

  anatawa12

  committed
  6e8120b

  Copy full SHA for 6e8120b

Commits on Aug 8, 2023

• DosStubSignature -> DosImageSignature

  anatawa12

  committed
  b829782

  Copy full SHA for b829782

• move AppWithUnknownLanguageResource to Microsoft.NET.HostModel.AppHost.Tests

  anatawa12

  committed
  fe92cc3

  Copy full SHA for fe92cc3

• Merge branch 'dotnet:main' into crossplatform-resource-updater

  anatawa12

  authored
  1470480

  Copy full SHA for 1470480

• Merge branch 'dotnet:main' into crossplatform-resource-updater

  anatawa12

  authored
  65f23d4

  Copy full SHA for 65f23d4