Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify hardware feature detection between CoreCLR JIT and AOT #89342

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Unify hardware feature detection between CoreCLR JIT and AOT #89342

merged 2 commits into from
Jul 23, 2023

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jul 22, 2023

Follow up on #87865

@ghost ghost assigned jkotas Jul 22, 2023
jkotas
jkotas commented Jul 22, 2023
View reviewed changes
src/coreclr/gc/vxsort/isa_detection.cpp
if (hMod == NULL)
return 0;

pfnGetEnabledXStateFeatures = (PGETENABLEDXSTATEFEATURES)GetProcAddress(hMod, "GetEnabledXStateFeatures");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

runtime/src/coreclr/vm/threadsuspend.cpp

Line 1972 in 08a6e06

DWORD64 FeatureMask = GetEnabledXStateFeatures();
links to GetEnabledXStateFeatures directly, so it is safe to delete the dynamic linking here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that the original reason for the dynamic linking was to support Windows 7 prior to SP1.

With Win7 support having been dropped and us just not regressing Win 7 SP1 and later, this is fine.

jkotas
jkotas commented Jul 22, 2023
View reviewed changes
src/coreclr/nativeaot/Runtime/i386/MemClrForGC.asm
@@ -1,148 +0,0 @@
;; Licensed to the .NET Foundation under one or more agreements.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have noticed these unused files thanks to IsProcessorFeaturePresent call.

This was referenced Jul 22, 2023
Closed
Closed
@jkotas jkotas changed the title Unity hardware feature detection between CoreCLR JIT and AOT Unify hardware feature detection between CoreCLR JIT and AOT Jul 22, 2023
@am11
Copy link
Member

am11 commented Jul 22, 2023

cc @gbalykov, if we ever added RISC-V support in src/native/minipal/cpufeatures.c, I think we can make it return the features per-hart (as each hardware thread in RISC-V can technically have different features, e.g. virtual memory range sizes; for which GC can be fine-tuned).

@build-analysis build-analysis bot mentioned this pull request Jul 22, 2023
Open
@jkotas jkotas merged commit 66556c4 into dotnet:main Jul 23, 2023
174 of 178 checks passed
@jkotas jkotas deleted the intrinsic-detection branch July 23, 2023 04:13
@jkotas jkotas mentioned this pull request Jul 25, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

Assignees

@jkotas jkotas

Labels
area-PAL-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotas @am11 @tannergooding