Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential BitCast bug for platforms without unaligned reads #89364

Merged
merged 1 commit into from
Jul 23, 2023

Conversation

MichalPetryka
Copy link
Contributor

BitCast could potentially make an invalid read when reinterpreting a type to another that requires higher alignment, which could possibly cause a fault on Mono ARMv6.

BitCast could potentially make an invalid read when reinterpreting a type to another that requires higher alignment, which could possibly cause a fault on Mono ARMv6.
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 23, 2023
@ghost
Copy link

ghost commented Jul 23, 2023

Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices
See info in area-owners.md if you want to be subscribed.

Issue Details

BitCast could potentially make an invalid read when reinterpreting a type to another that requires higher alignment, which could possibly cause a fault on Mono ARMv6.

Author: MichalPetryka
Assignees: -
Labels:

area-System.Runtime.CompilerServices, community-contribution

Milestone: -

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@jkotas jkotas merged commit 65536eb into dotnet:main Jul 23, 2023
@MichalPetryka MichalPetryka deleted the patch-15 branch July 23, 2023 19:22
@ghost ghost locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.CompilerServices community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants